add support for Debian 13 #321
Conversation
spec/classes/snmp_init_spec.rb
Outdated
| # in this case | ||
| case facts[:os]['release']['major'] | ||
| when '11', '12' | ||
| when '11', '12', '13' |
There was a problem hiding this comment.
I think the whole case statement can go away now?
There was a problem hiding this comment.
Yes it can. After simplification, this stays:
describe 'manage_snmpdtrapd => false Debian' do
let(:params) { { manage_snmptrapd: false } }
end
I've no idea what it means, I don't speak ruby :/ So I'm unsure if this could disappear too.
There was a problem hiding this comment.
This means you try a test with with parameter manage_snmptrapd: false on Debian, this can stay
There was a problem hiding this comment.
It seems like removing the case breaks things. I don't understand why :(
| when '11', '12', '13' | ||
| it { is_expected.to contain_file('snmpd.sysconfig').without_content(%r{TRAPDRUN|TRAPDOPTS}) } | ||
| end | ||
| end |
There was a problem hiding this comment.
This test doesn't really make a lot of sense to me as you don't test something specific for the parameter you set.
So either remove this whole describe block or actually test what the expected behavior would be.
In the describe block under let parameters you can add the following:
it { is_expected.not_to contain_systemd__dropin_file('snmptrapd.conf') }
it { is_expected.not_to contain_file('snmptrapd.sysconfig') }
There was a problem hiding this comment.
@bastelfreak What are your thoughts on this?
4 participants
Pull Request (PR) description
add support for Debian 13
This Pull Request (PR) fixes the following issues