Feature/ft create sortable (#533)

* Add SORTABLE option to FT.CREATE and ignore it

Signed-off-by: Alexandru Filip <[email protected]>

* Add tests

Signed-off-by: Alexandru Filip <[email protected]>

* Fix flaky test (#530)

* Fix flaky test

Signed-off-by: Allen Samuels <[email protected]>

* Fix CME too

Signed-off-by: Allen Samuels <[email protected]>

---------

Signed-off-by: Allen Samuels <[email protected]>

---------

Signed-off-by: Alexandru Filip <[email protected]>
Signed-off-by: Allen Samuels <[email protected]>
Co-authored-by: Allen Samuels <[email protected]>

Author: AlexFilipImproving

COMMANDS.md

@@ -25,7 +25,8 @@ FT.CREATE <index-name>
             <field-identifier> [AS <field-alias>] 
                   NUMERIC 
                 | TAG [SEPARATOR <sep>] [CASESENSITIVE] 
-                | VECTOR [HNSW | FLAT] <attr_count> [<attribute_name> <attribute_value>]+)
+                | VECTOR [HNSW | FLAT] <attr_count> [<attribute_name> <attribute_value>]+
+            [SORTABLE]
         )+
 ```
 
@@ -61,6 +62,10 @@ FT.CREATE <index-name>
   - **EF\_CONSTRUCTION \<number\>** (optional): controls the number of vectors examined during index construction. Higher values for this parameter will improve recall ratio at the expense of longer index creation times. The default value is 200\. Maximum value is 4096\.  
   - **EF\_RUNTIME \<number\>** (optional):  controls  the number of vectors to be examined during a query operation. The default is 10, and the max is 4096\. You can set this parameter value for each query you run. Higher values increase query times, but improve query recall.
 
+### Field options
+
+**SORTABLE**: This parameter is currently ignored as all field types are considered to be sortable
+
 **RESPONSE** OK or error.
 
 ## FT.DROPINDEX

src/commands/ft_create_parser.cc

@@ -404,6 +404,18 @@ absl::StatusOr<data_model::Attribute *> ParseAttributeArgs(
   } else {
     CHECK(false);
   }
+
+  // Check for SORTABLE option and ignore it
+  if (itr.DistanceEnd() > 0) {
+    auto next_arg = itr.Get();
+    if (next_arg.ok()) {
+      absl::string_view order_str = vmsdk::ToStringView(next_arg.value());
+      if (absl::EqualsIgnoreCase(order_str, "SORTABLE")) {
+        itr.Next();
+      }
+    }
+  }
+
   attribute_proto->set_allocated_index(index_proto.release());
   return attribute_proto;
 }

testing/ft_create_test.cc

@@ -188,6 +188,26 @@ INSTANTIATE_TEST_SUITE_P(
                     },
                 },
         },
+        {
+            .test_name = "happy_path_sortable",
+            .argv = {"FT.CREATE", "test_index_schema", "schema", "field1",
+                     "numeric", "SORTABLE", "field2", "tag", "separator", "|",
+                     "sortable"},
+            .index_schema_name = "test_index_schema",
+            .expected_run_return = VALKEYMODULE_OK,
+            .expected_reply_message = "+OK\r\n",
+            .expected_indexes =
+                {
+                    {
+                        .attribute_alias = "field1",
+                        .indexer_type = indexes::IndexerType::kNumeric,
+                    },
+                    {
+                        .attribute_alias = "field2",
+                        .indexer_type = indexes::IndexerType::kTag,
+                    },
+                },
+        },
     }),
     [](const TestParamInfo<FTCreateTestCase>& info) {
       return info.param.test_name;