feat: use safariviewcontroller for github issue prefill

Author: castdrian

Makefile

@@ -11,7 +11,7 @@ include $(THEOS)/makefiles/common.mk
 TWEAK_NAME = Unbound
 $(TWEAK_NAME)_FILES = $(shell find sources -name "*.x*" -o -name "*.m*")
 $(TWEAK_NAME)_CFLAGS = -fobjc-arc -DPACKAGE_VERSION='@"$(THEOS_PACKAGE_BASE_VERSION)"' -DCOMMIT_HASH='@"$(COMMIT_HASH)"' -I$(THEOS_PROJECT_DIR)/headers
-$(TWEAK_NAME)_FRAMEWORKS = UIKit Foundation UniformTypeIdentifiers UserNotifications Security
+$(TWEAK_NAME)_FRAMEWORKS = UIKit Foundation UniformTypeIdentifiers UserNotifications Security SafariServices
 
 BUNDLE_NAME = UnboundResources
 $(BUNDLE_NAME)_INSTALL_PATH = "/Library/Application\ Support/"

headers/Recovery.h

@@ -1,6 +1,7 @@
 #import <Foundation/Foundation.h>
 #import <UIKit/UIKit.h>
 #import <UniformTypeIdentifiers/UniformTypeIdentifiers.h>
+#import <SafariServices/SafariServices.h>
 #import <objc/message.h>
 #import <spawn.h>
 #import <sys/utsname.h>
@@ -9,14 +10,15 @@
 #import "Settings.h"
 #import "Updater.h"
 #import "Utilities.h"
+#import "MobileGestalt.h"
 
 BOOL      isRecoveryModeEnabled(void);
 void      showMenuSheet(void);
 void      reloadApp(UIViewController *viewController);
 
 extern id gBridge;
 
-@interface UnboundMenuViewController : UIViewController <UITableViewDelegate, UITableViewDataSource>
+@interface UnboundMenuViewController : UIViewController <UITableViewDelegate, UITableViewDataSource, SFSafariViewControllerDelegate>
 
 @property (nonatomic, strong) UITableView *tableView;
 

sources/Recovery.x

@@ -1,8 +1,5 @@
-#import "MobileGestalt.h"
 #import "Recovery.h"
 
-#pragma mark - Gesture Handling
-
 static NSTimeInterval shakeStartTime      = 0;
 static BOOL           isShaking           = NO;
 static NSHashTable   *windowsWithGestures = nil;
@@ -329,8 +326,6 @@ BOOL isRecoveryModeEnabled(void)
     return cell;
 }
 
-#pragma mark - Table View Delegate
-
 - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath
 {
     [tableView deselectRowAtIndexPath:indexPath animated:YES];
@@ -347,8 +342,6 @@ BOOL isRecoveryModeEnabled(void)
     }
 }
 
-#pragma mark - Menu Actions
-
 - (void)showDestructiveConfirmation:(NSString *)action selectorName:(NSString *)selectorName
 {
     NSString *message = @"Are you sure you want to do this?";
@@ -407,8 +400,6 @@ BOOL isRecoveryModeEnabled(void)
     [self dismissViewControllerAnimated:YES completion:^{ reloadApp(self); }];
 }
 
-#pragma mark - Bundle Management
-
 - (void)switchBundleVersion
 {
     UIAlertController *loadingAlert =
@@ -701,8 +692,6 @@ BOOL isRecoveryModeEnabled(void)
     [self dismissViewControllerAnimated:YES completion:^{ reloadApp(self); }];
 }
 
-#pragma mark - Utility Functions
-
 - (void)openAppFolder
 {
     if ([Utilities isJailbroken])
@@ -787,7 +776,17 @@ BOOL isRecoveryModeEnabled(void)
         stringWithFormat:@"https://github.com/unbound-app/client/issues/new?title=%@&body=%@",
                          encodedTitle, encodedBody];
     NSURL    *url       = [NSURL URLWithString:urlString];
-    [[UIApplication sharedApplication] openURL:url options:@{} completionHandler:nil];
+
+    if (!url)
+    {
+        return;
+    }
+
+    SFSafariViewController *safari = [[SFSafariViewController alloc] initWithURL:url];
+    safari.dismissButtonStyle      = SFSafariViewControllerDismissButtonStyleClose;
+    safari.delegate                = self;
+    safari.modalPresentationStyle  = UIModalPresentationPageSheet;
+    [self presentViewController:safari animated:YES completion:nil];
 }
 
 - (void)toggleSetting:(UISwitch *)sender
@@ -850,13 +849,16 @@ BOOL isRecoveryModeEnabled(void)
     [defaults synchronize];
 }
 
+- (void)safariViewControllerDidFinish:(SFSafariViewController *)controller
+{
+    [controller dismissViewControllerAnimated:YES completion:nil];
+}
+
 - (void)dismiss
 {
     [self dismissViewControllerAnimated:YES completion:nil];
 }
 
-#pragma mark - Helper Functions
-
 void showMenuSheet(void)
 {
     UnboundMenuViewController *settingsVC = [[UnboundMenuViewController alloc] init];