AP-1531 Zero-pad fixed-length binary fields (#1123)

Author: Samira-El

pipelinewise/fastsync/commons/tap_mysql.py

@@ -357,7 +357,7 @@ def get_table_columns(self, table_name, max_num=None, date_type='date'):
                             WHEN data_type IN ('blob', 'tinyblob', 'mediumblob', 'longblob')
                                     THEN CONCAT('REPLACE(hex(`', column_name, '`)', ", '\n', ' ')")
                             WHEN data_type IN ('binary', 'varbinary')
-                                    THEN concat('REPLACE(REPLACE(hex(trim(trailing CHAR(0x00) from `',COLUMN_NAME,'`))', ", '\n', ' '), '\r', '')")
+                                    THEN concat('REPLACE(REPLACE(hex(`',COLUMN_NAME,'`)', ", '\n', ' '), '\r', '')")
                             WHEN data_type IN ('bit')
                                     THEN concat('cast(`', column_name, '` AS unsigned)')
                             WHEN data_type IN ('date')

singer-connectors/tap-mysql/requirements.txt

@@ -1 +1 @@
-pipelinewise-tap-mysql==1.5.5
+pipelinewise-tap-mysql==1.5.6

tests/db/tap_mysql_data.sql

@@ -1608,7 +1608,7 @@ DROP TABLE IF EXISTS `all_datatypes`;
 CREATE TABLE `all_datatypes` (
     c_char                  CHAR        PRIMARY KEY,
     c_varchar               VARCHAR(100),
-    c_binary                BINARY,
+    c_binary                BINARY(6),
     c_varbinary             VARBINARY(100),
     c_blob                  BLOB,
     c_tinyblob              TINYBLOB,