feat(es/minifier): Implement more rules (#1871)

swc_ecma_codegen:
 - Fix codegen of `U+0028` and `U+0029`. 

swc_ecma_minifier:
 - Implement MVP.

swc_ecma_transforms_base:
 - `fixer`: Handle seq/await in rhs of for-of.

Author: kdy1

.github/workflows/cargo.yml

@@ -160,7 +160,7 @@ jobs:
       # Source map format
       - uses: actions/setup-node@v2
         with:
-          node-version: "14"
+          node-version: "16"
 
       # We explicitly do this to cache properly.
       - name: Install Rust
@@ -170,7 +170,7 @@ jobs:
 
       - uses: actions/setup-node@v2
         with:
-          node-version: 14
+          node-version: 16
 
       - uses: denoland/setup-deno@v1
         with:

Cargo.lock

@@ -6,7 +6,7 @@ edition = "2018"
 license = "Apache-2.0/MIT"
 name = "swc_ecmascript"
 repository = "https://github.com/swc-project/swc.git"
-version = "0.48.0"
+version = "0.49.0"
 
 [package.metadata.docs.rs]
 all-features = true
@@ -34,7 +34,7 @@ typescript = ["typescript-parser", "swc_ecma_transforms/typescript"]
 swc_ecma_ast = {version = "0.49.0", path = "./ast"}
 swc_ecma_codegen = {version = "0.64.0", path = "./codegen", optional = true}
 swc_ecma_dep_graph = {version = "0.33.0", path = "./dep-graph", optional = true}
-swc_ecma_minifier = {version = "0.14.0", path = "./minifier", optional = true}
+swc_ecma_minifier = {version = "0.15.0", path = "./minifier", optional = true}
 swc_ecma_parser = {version = "0.65.0", path = "./parser", optional = true, default-features = false}
 swc_ecma_transforms = {version = "0.61.0", path = "./transforms", optional = true}
 swc_ecma_utils = {version = "0.41.0", path = "./utils", optional = true}

ecmascript/Cargo.toml

@@ -7,7 +7,7 @@ include = ["Cargo.toml", "src/**/*.rs"]
 license = "Apache-2.0/MIT"
 name = "swc_ecma_codegen"
 repository = "https://github.com/swc-project/swc.git"
-version = "0.64.1"
+version = "0.64.2"
 
 [dependencies]
 bitflags = "1"

ecmascript/codegen/Cargo.toml

@@ -2543,6 +2543,13 @@ fn escape_without_source(v: &str, target: JscTarget, single_quote: bool) -> Stri
                 let _ = write!(buf, "\\x{:x}", c as u8);
             }
 
+            '\u{2028}' => {
+                buf.push_str("\\u2028");
+            }
+            '\u{2029}' => {
+                buf.push_str("\\u2029");
+            }
+
             _ => {
                 buf.push(c);
             }

ecmascript/codegen/src/lib.rs

@@ -560,7 +560,7 @@ fn test_escape_without_source() {
     es2020("abcde", "abcde");
     es2020(
         "\x00\r\n\u{85}\u{2028}\u{2029};",
-        "\\x00\\r\\n\\x85\u{2028}\u{2029};",
+        "\\x00\\r\\n\\x85\\u2028\\u2029;",
     );
 
     es2020("\n", "\\n");

ecmascript/codegen/src/tests.rs

@@ -0,0 +1,47 @@
+{
+    "parser": "babel-eslint",
+    "rules": {
+        "indent": [
+            "error",
+            4
+        ],
+        "semi": [
+            "error",
+            "always"
+        ],
+        "space-unary-ops": 2,
+        "no-undef": "off",
+        "consistent-return": "off",
+        "no-prototype-builtins": "off",
+        "no-cond-assign": "off",
+        "multiline-ternary": [
+            "error",
+            "always-multiline"
+        ],
+        "object-property-newline": [
+            "error",
+            {
+                "allowAllPropertiesOnSameLine": false
+            }
+        ],
+        "function-call-argument-newline": [
+            "error",
+            "always"
+        ],
+        "object-curly-newline": [
+            "error",
+            "always"
+        ],
+        "comma-dangle": [
+            "error",
+            "always"
+        ],
+        "function-paren-newline": [
+            "error",
+            "always"
+        ],
+        "no-trailing-spaces": [
+            "error"
+        ]
+    }
+}

ecmascript/minifier/.eslintrc

@@ -0,0 +1,2 @@
+# Used to see ideal output using terser
+lab.js

ecmascript/minifier/.gitignore

@@ -7,13 +7,14 @@ include = ["Cargo.toml", "src/**/*.rs", "src/lists/*.json"]
 license = "Apache-2.0/MIT"
 name = "swc_ecma_minifier"
 repository = "https://github.com/swc-project/swc.git"
-version = "0.14.0"
+version = "0.15.0"
 
 [features]
 debug = []
 
 [dependencies]
 fxhash = "0.2.1"
+indexmap = "1.7.0"
 log = "0.4"
 once_cell = "1.5.2"
 pretty_assertions = {version = "0.6.1", optional = true}
@@ -31,10 +32,12 @@ swc_ecma_transforms = {version = "0.61.0", path = "../transforms/", features = [
 swc_ecma_transforms_base = {version = "0.24.0", path = "../transforms/base"}
 swc_ecma_utils = {version = "0.41.0", path = "../utils"}
 swc_ecma_visit = {version = "0.35.0", path = "../visit"}
+unicode-xid = "0.2.2"
 
 [dev-dependencies]
 ansi_term = "0.12.1"
 anyhow = "1"
 pretty_assertions = "0.6.1"
+swc_node_base = {version = "0.2.0", path = "../../node/base"}
 testing = {version = "0.12.0", path = "../../testing"}
 walkdir = "2.3.1"

ecmascript/minifier/Cargo.toml

@@ -8,6 +8,26 @@ Currently name mangler is very simple. To focus on creating a MVP, I (kdy1) will
 
 ## Testing
 
+### Real-library tests
+
+You can use vscode to see diffs. Select a file from `tests/projects/output` and select the corresponding file from `tests/projects/refs`. Then you can right click to see an option to open diff.
+
+#### Splitting a library test
+
+Extracting only subset from a library test makes development much easier.
+
+Split status:
+
+-   [ ] angular-1.2.5
+-   [x] backbone-1.1.0
+-   [ ] jquery-1.9.1
+-   [ ] jquery.mobile-1.4.2
+-   [ ] mootools-1.4.5
+-   [x] underscore-1.5.2
+-   [ ] yui-3.12.0
+
+### Tests from terser
+
 Tests ported from terser has
 
 -   input.js
@@ -16,6 +36,6 @@ Tests ported from terser has
 -   output.js (if exists and can be modified if our one is better or due to lack of frequency-aware base54)
 -   output.terser.js (if exists)
 
-## Copying tests
+#### Copying tests
 
 Replace the content of `terser/test/compress.js` with it of `scripts/compress.js` and run `npm run test:compress`