-
-
Notifications
You must be signed in to change notification settings - Fork 603
feat: update Optional/Union annotations to use the "|" syntax #4019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @bellini666, your pull request is larger than the review limit of 150000 diff characters
1791934 to
4a597b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @bellini666, your pull request is larger than the review limit of 150000 diff characters
4a597b2 to
2a89581
Compare
|
Hi, thanks for contributing to Strawberry 🍓! We noticed that this PR is missing a So as soon as this PR is merged, a release will be made 🚀. Here's an example of Release type: patch
Description of the changes, ideally with some examples, if adding a new feature.Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :) Here's the tweet text: |
2a89581 to
6311865
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bde0b0a to
76e2f54
Compare
Apollo Federation Subgraph Compatibility Results
Learn more: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4019 +/- ##
==========================================
- Coverage 94.41% 94.37% -0.04%
==========================================
Files 532 532
Lines 34773 34736 -37
Branches 1828 1828
==========================================
- Hits 32831 32783 -48
- Misses 1647 1657 +10
- Partials 295 296 +1 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #4019 will not alter performanceComparing Summary
|
197b17e to
0360b50
Compare
0360b50 to
bcaadfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @bellini666, your pull request is larger than the review limit of 150000 diff characters
patrick91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D
Based on top of #4018