-
-
Notifications
You must be signed in to change notification settings - Fork 603
ci: update pytest-codspeed to 4.2.0 to fix installation issues #4063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates pytest-codspeed to 4.2.0 to fix a macOS installation bug and adjusts the CI benchmark workflow to use the newer CodSpeed GitHub Action with OIDC-based authentication and simulation mode. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be35453 to
1beeead
Compare
|
Hi, thanks for contributing to Strawberry 🍓! We noticed that this PR is missing a So as soon as this PR is merged, a release will be made 🚀. Here's an example of Release type: patch
Description of the changes, ideally with some examples, if adding a new feature.Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :) Here's the tweet text: |
Greptile OverviewGreptile SummaryThis PR fixes pytest-codspeed installation issues by bumping from
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant GH as GitHub Actions
participant OIDC as OIDC Provider
participant CS as CodSpeed Service
participant PT as pytest-codspeed
GH->>OIDC: Request ID token (id-token: write)
OIDC-->>GH: Return signed JWT
GH->>CS: Authenticate via OIDC token
CS-->>GH: Grant access
GH->>PT: Run benchmarks (simulation mode)
PT-->>GH: Benchmark results
GH->>CS: Upload benchmark data
CS-->>GH: Acknowledge receipt
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
Apollo Federation Subgraph Compatibility Results
Learn more: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the benchmarking infrastructure to resolve a macOS installation bug in pytest-codspeed 4.1.0 by upgrading to version 4.2.0, and modernizes the CI workflow to use more secure OIDC authentication.
- Updates
pytest-codspeeddependency from>=3.0.0to>=4.2.0to fix a symlink loop bug - Migrates CodSpeed CI workflow from token-based authentication to OIDC
- Changes benchmark execution mode from instrumentation to simulation
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyproject.toml |
Bumps pytest-codspeed minimum version constraint from >=3.0.0 to >=4.2.0 |
poetry.lock |
Updates pytest-codspeed from 4.1.0 to 4.2.0 with new file hashes and Python 3.14 support |
.gitignore |
Adds .codspeed/ directory to ignore CodSpeed-generated artifacts |
.github/workflows/test.yml |
Adds OIDC permissions, updates CodSpeed action to v4, removes token parameter, and switches to simulation mode |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4063 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 536 536
Lines 35036 35036
Branches 1842 1842
=======================================
Hits 33079 33079
Misses 1659 1659
Partials 298 298 🚀 New features to boost your workflow:
|
- Bump pytest-codspeed from >=3.0.0 to >=4.2.0 to fix symlink loop bug in 4.1.0 that caused 'File name too long' errors on macOS - Update CI workflow to use OIDC authentication instead of token - Switch CodSpeed action to v4 with simulation mode
CodSpeed Performance ReportMerging #4063 will not alter performanceComparing Summary
|
1beeead to
255a19f
Compare
Summary
instrument-hooks/examplethat caused "File name too long" errors duringpoetry installon macOSChanges
pyproject.toml: Bumppytest-codspeedfrom>=3.0.0to>=4.2.0poetry.lock: Updated to pytest-codspeed 4.2.0.github/workflows/test.yml:permissions: contents: read, id-token: writefor OIDC authCodSpeedHQ/actionfromv4.1.1tov4token: ${{ secrets.CODSPEED_TOKEN }}(OIDC handles auth)mode: instrumentationtomode: simulationTesting
Summary by Sourcery
Update benchmarking tooling and CI configuration to resolve pytest-codspeed installation issues and modernize CodSpeed integration.
Bug Fixes:
Enhancements:
CI: