Add support for Python 3.14 (#3828)

patrick91 · greptile-apps[bot] · web-flow · commit 258ce9598df3 · 2025-10-07T18:23:38.000+01:00
* Run tests on 3.14 * Fix deps * Bump graphql core 3.2 * Fix doc param * Apply suggestion from @greptile-apps[bot] Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Fix doc param * Keep 3.9 * Use annotationlib in 3.14 * Fix date error assert * Use get_annotations from typing_extensions * Fix union * Mypy * Type ignore and pydantic version * Fix brokenness * :) * Does it click * Pydantic is all you need * SUPERSANIC * Less dev * Keep dev for now * 🔦🔦🔦🔦🔦🔦🔦🔦🔦🔦🔦 --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
diff --git a/.github/workflows/codeflash.yaml b/.github/workflows/codeflash.yaml
@@ -38,4 +38,4 @@ jobs:
       - name: Run Codeflash to optimize code
         run: |
           poetry env use python
-          poetry run codeflash --benchmark
+          poetry run codeflash --benchmark --benchmarks-root tests/benchmarks
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -62,6 +62,7 @@ jobs:
             3.11
             3.12
             3.13
+            3.14-dev
 
       - run: pip install poetry nox nox-poetry uv
       - run: nox -r -t tests -s "${{ matrix.session.session }}"
diff --git a/RELEASE.md b/RELEASE.md
@@ -0,0 +1,3 @@
+Release type: patch
+
+This release adds support for the upcoming Python 3.14
diff --git a/TWEET.md b/TWEET.md
@@ -0,0 +1,5 @@
+🆕 Release $version is out! Thanks to $contributor for the PR 👏
+
+This release adds support for Python 3.14!
+
+Get it here 👉 $release_url
diff --git a/noxfile.py b/noxfile.py
@@ -8,10 +8,10 @@
 nox.options.error_on_external_run = True
 nox.options.default_venv_backend = "uv"
 
-PYTHON_VERSIONS = ["3.13", "3.12", "3.11", "3.10", "3.9"]
+PYTHON_VERSIONS = ["3.14", "3.13", "3.12", "3.11", "3.10", "3.9"]
 
 GQL_CORE_VERSIONS = [
-    "3.2.3",
+    "3.2.6",
     "3.3.0a9",
 ]
 
@@ -129,12 +129,35 @@ def tests_integrations(session: Session, integration: str, gql_core: str) -> Non
     session.run("pytest", *COMMON_PYTEST_OPTIONS, "-m", integration)
 
 
+@session(
+    python=["3.9", "3.10", "3.11", "3.12", "3.13"],
+    name="Pydantic V1 tests",
+    tags=["tests", "pydantic"],
+)
+@gql_core_parametrize
+def test_pydantic(session: Session, gql_core: str) -> None:
+    session.run_always("poetry", "install", "--without=integrations", external=True)
+
+    session._session.install("pydantic~=1.10")  # type: ignore
+    _install_gql_core(session, gql_core)
+    session.run(
+        "pytest",
+        "--cov=.",
+        "--cov-append",
+        "--cov-report=xml",
+        "-m",
+        "pydantic",
+        "--ignore=tests/cli",
+        "--ignore=tests/benchmarks",
+    )
+
+
 @session(python=PYTHON_VERSIONS, name="Pydantic tests", tags=["tests", "pydantic"])
-@with_gql_core_parametrize("pydantic", ["1.10", "2.9.0", "2.10.0", "2.11.0"])
-def test_pydantic(session: Session, pydantic: str, gql_core: str) -> None:
+@gql_core_parametrize
+def test_pydantic_v2(session: Session, gql_core: str) -> None:
     session.run_always("poetry", "install", "--without=integrations", external=True)
 
-    session._session.install(f"pydantic~={pydantic}")  # type: ignore
+    session._session.install("pydantic~=2.12")  # type: ignore
     _install_gql_core(session, gql_core)
     session.run(
         "pytest",
@@ -166,7 +189,8 @@ def tests_typecheckers(session: Session) -> None:
     )
 
 
-@session(python=PYTHON_VERSIONS, name="CLI tests", tags=["tests"])
+# skipping python 3.9 because of some changes in click 8.2.0
+@session(python=PYTHON_VERSIONS[:-1], name="CLI tests", tags=["tests"])
 def tests_cli(session: Session) -> None:
     session.run_always("poetry", "install", "--without=integrations", external=True)
 
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -117,7 +117,7 @@ dev = [
   "mypy (>=1.15.0,<2.0.0)",
   "pyright (==1.1.401)",
   "codeflash (>=0.9.2)",
-  "pre-commit (>=4.3.0,<5.0.0)",
+  "pre-commit",
 ]
 integrations = [
   "aiohttp (>=3.7.4.post0,<4.0.0)",
diff --git a/strawberry/schema/_graphql_core.py b/strawberry/schema/_graphql_core.py
@@ -7,16 +7,16 @@
 from strawberry.types import ExecutionResult
 
 try:
-    from graphql import (
-        ExperimentalIncrementalExecutionResults as GraphQLIncrementalExecutionResults,  # type: ignore[attr-defined]
+    from graphql import (  # type: ignore[attr-defined]
+        ExperimentalIncrementalExecutionResults as GraphQLIncrementalExecutionResults,
     )
-    from graphql.execution import (
-        InitialIncrementalExecutionResult,  # type: ignore[attr-defined]
-        experimental_execute_incrementally,  # type: ignore[attr-defined]
+    from graphql.execution import (  # type: ignore[attr-defined]
+        InitialIncrementalExecutionResult,
+        experimental_execute_incrementally,
     )
-    from graphql.type.directives import (
-        GraphQLDeferDirective,  # type: ignore[attr-defined]
-        GraphQLStreamDirective,  # type: ignore[attr-defined]
+    from graphql.type.directives import (  # type: ignore[attr-defined]
+        GraphQLDeferDirective,
+        GraphQLStreamDirective,
     )
 
     incremental_execution_directives = (
diff --git a/strawberry/types/field.py b/strawberry/types/field.py
@@ -98,6 +98,10 @@ def __init__(
         if sys.version_info >= (3, 10):
             kwargs["kw_only"] = dataclasses.MISSING
 
+        # doc was added to python 3.14 and it is required
+        if sys.version_info >= (3, 14):
+            kwargs["doc"] = None
+
         super().__init__(
             default=default,
             default_factory=default_factory,  # type: ignore
diff --git a/strawberry/types/object_type.py b/strawberry/types/object_type.py
@@ -12,7 +12,7 @@
     Union,
     overload,
 )
-from typing_extensions import dataclass_transform
+from typing_extensions import dataclass_transform, get_annotations
 
 from strawberry.exceptions import (
     InvalidSuperclassInterfaceError,
@@ -51,7 +51,8 @@ def _check_field_annotations(cls: builtins.type[Any]) -> None:
 
     https://github.com/python/cpython/blob/6fed3c85402c5ca704eb3f3189ca3f5c67a08d19/Lib/dataclasses.py#L881-L884
     """
-    cls_annotations = cls.__dict__.get("__annotations__", {})
+    cls_annotations = get_annotations(cls)
+    # TODO: do we need this?
     cls.__annotations__ = cls_annotations
 
     for field_name, field_ in cls.__dict__.items():
diff --git a/strawberry/utils/typing.py b/strawberry/utils/typing.py
@@ -110,9 +110,8 @@ def get_optional_annotation(annotation: type) -> type:
 
     # if we have multiple non none types we want to return a copy of this
     # type (normally a Union type).
-
     if len(non_none_types) > 1:
-        return annotation.copy_with(non_none_types)  # type: ignore[attr-defined]
+        return Union[non_none_types]  # type: ignore
 
     return non_none_types[0]
 
diff --git a/tests/cli/test_locate_definition.py b/tests/cli/test_locate_definition.py
@@ -42,7 +42,7 @@ def test_find_missing_model(cli_app: Typer, cli_runner: CliRunner):
     result = cli_runner.invoke(cli_app, ["locate-definition", selector, "Missing"])
 
     assert result.exit_code == 1
-    assert result.stdout.strip() == snapshot("Definition not found: Missing")
+    assert result.stderr.strip() == snapshot("Definition not found: Missing")
 
 
 def test_find_missing_model_field(cli_app: Typer, cli_runner: CliRunner):
@@ -52,7 +52,7 @@ def test_find_missing_model_field(cli_app: Typer, cli_runner: CliRunner):
     )
 
     assert result.exit_code == 1
-    assert result.stdout.strip() == snapshot("Definition not found: Missing.field")
+    assert result.stderr.strip() == snapshot("Definition not found: Missing.field")
 
 
 def test_find_missing_schema(cli_app: Typer, cli_runner: CliRunner):
diff --git a/tests/experimental/pydantic/schema/test_1_and_2.py b/tests/experimental/pydantic/schema/test_1_and_2.py
@@ -1,10 +1,17 @@
+import sys
 import textwrap
 from typing import Optional, Union
 
+import pytest
+
 import strawberry
 from tests.experimental.pydantic.utils import needs_pydantic_v2
 
 
+@pytest.mark.skipif(
+    sys.version_info >= (3, 14),
+    reason="Pydantic v1 is not compatible with Python 3.14+",
+)
 @needs_pydantic_v2
 def test_can_use_both_pydantic_1_and_2():
     import pydantic
diff --git a/tests/schema/types/test_date.py b/tests/schema/types/test_date.py
@@ -113,7 +113,7 @@ def test_serialization_error_message_for_incorrect_date_string():
     """
     result = execute_mutation("2021-13-01")
     assert result.errors
-    assert result.errors[0].message == (
+    assert result.errors[0].message.startswith(
         "Variable '$value' got invalid value '2021-13-01'; Value cannot represent a "
         'Date: "2021-13-01". month must be in 1..12'
     )
diff --git a/tests/schema/types/test_datetime.py b/tests/schema/types/test_datetime.py
@@ -163,7 +163,7 @@ def test_serialization_error_message_for_incorrect_datetime_string():
     """
     result = execute_mutation("2021-13-01T09:00:00")
     assert result.errors
-    assert result.errors[0].message == (
+    assert result.errors[0].message.startswith(
         "Variable '$value' got invalid value '2021-13-01T09:00:00'; Value cannot "
         'represent a DateTime: "2021-13-01T09:00:00". month must be in 1..12'
     )
diff --git a/tests/schema/types/test_time.py b/tests/schema/types/test_time.py
@@ -112,7 +112,7 @@ def test_serialization_error_message_for_incorrect_time_string():
     """
     result = execute_mutation("25:00")
     assert result.errors
-    assert result.errors[0].message == (
+    assert result.errors[0].message.startswith(
         "Variable '$value' got invalid value '25:00'; Value cannot represent a "
         'Time: "25:00". hour must be in 0..23'
     )
diff --git a/tests/typecheckers/utils/mypy.py b/tests/typecheckers/utils/mypy.py
@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import json
+import os
 import pathlib
 import subprocess
 import tempfile
@@ -52,7 +53,13 @@ def run_mypy(code: str, strict: bool = True) -> list[Result]:
         module_path.write_text(code)
 
         process_result = subprocess.run(
-            [*args, str(module_path)], check=False, capture_output=True
+            [*args, str(module_path)],
+            check=False,
+            capture_output=True,
+            env={
+                "PYTHONWARNINGS": "error,ignore::SyntaxWarning",
+                "PATH": os.environ["PATH"],
+            },
         )
 
         full_output = (

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+Release type: patch`
	`2`	`+`
	`3`	`+This release adds support for the upcoming Python 3.14`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ dev = [`
`117`	`117`	`"mypy (>=1.15.0,<2.0.0)",`
`118`	`118`	`"pyright (==1.1.401)",`
`119`	`119`	`"codeflash (>=0.9.2)",`
`120`		`- "pre-commit (>=4.3.0,<5.0.0)",`
	`120`	`+ "pre-commit",`
`121`	`121`	`]`
`122`	`122`	`integrations = [`
`123`	`123`	`"aiohttp (>=3.7.4.post0,<4.0.0)",`