⚡️ Speed up function should_resolve_list_connection_edges by 46% (#3976)

* ⚡️ Speed up function `should_resolve_list_connection_edges` by 46%
Here is a rewritten, much faster version of your function.  
The efficiency improvement focuses on two major issues in the profile.

- The **nested for-loops** iterating through selections and recursing with a function that checks every node. This was incurring deep call overhead and duplicate checks.
- The **recursive _check_selection** can be replaced with an iterative approach using a stack to avoid deep Python recursion and to exit immediately on the first match.



**Summary of changes:**
- Eliminated all recursion by rewriting as a single iterative DFS using a stack, minimizing Python frame overhead.
- Only a single scan through the selection tree with immediate exit on finding a match (`edges`/`pageInfo`).
- Preserved the public API and all comments as required.
- No repeated checks for the same node, no walk of already-matched subtrees.

**You can expect** a substantial runtime improvement, especially with deeply nested or large queries, plus removal of risk of hitting the recursion limit.

* Apply suggestions from code review

* Update strawberry/relay/utils.py

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: codeflash-ai[bot] <148906541+codeflash-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

Author: 3 people

strawberry/relay/utils.py

@@ -7,7 +7,7 @@
 from typing_extensions import Self, assert_never
 
 from strawberry.types.base import StrawberryObjectDefinition
-from strawberry.types.nodes import InlineFragment, Selection
+from strawberry.types.nodes import InlineFragment
 
 if TYPE_CHECKING:
     from strawberry.types.info import Info
@@ -83,31 +83,19 @@ def should_resolve_list_connection_edges(info: Info) -> bool:
 
     """
     resolve_for_field_names = {"edges", "pageInfo"}
-
-    def _check_selection(selection: Selection) -> bool:
-        """Recursively inspect the selection to check if the user requested to resolve the `edges` field.
-
-        Args:
-            selection (Selection): The selection to check.
-
-        Returns:
-            bool: True if the user requested to resolve the `edges` field of a connection, False otherwise.
-        """
+    # Recursively inspect the selection to check if the user requested to resolve the `edges` field.
+    stack = []
+    for selection_field in info.selected_fields:
+        stack.extend(selection_field.selections)
+    while stack:
+        selection = stack.pop()
         if (
             not isinstance(selection, InlineFragment)
             and selection.name in resolve_for_field_names
         ):
             return True
-        if selection.selections:
-            return any(
-                _check_selection(selection) for selection in selection.selections
-            )
-        return False
-
-    for selection_field in info.selected_fields:
-        for selection in selection_field.selections:
-            if _check_selection(selection):
-                return True
+        if nested_selections := getattr(selection, "selections", None):
+            stack.extend(nested_selections)
     return False