Skip to content

Commit f6ed36e

Browse files
authored
Merge pull request #495 from okaufmann/implicit-nullables
Fix Remaining Nullable Parameter Definitions
2 parents 67e822d + 236133d commit f6ed36e

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

docs/advanced-usage/using-your-own-event-serializer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ the currency.
3434
```
3535
class UpgradeSerializer extends JsonEventSerializer
3636
{
37-
public function deserialize(string $eventClass, string $json, string $metadata = null): ShouldBeStored
37+
public function deserialize(string $eventClass, string $json, ?string $metadata = null): ShouldBeStored
3838
{
3939
$event = parent::deserialize($eventClass, $json, $metadata);
4040

src/EventSerializers/EventSerializer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ public function deserialize(
1212
string $eventClass,
1313
string $json,
1414
int $version,
15-
string $metadata = null
15+
?string $metadata = null
1616
): ShouldBeStored;
1717
}

src/EventSerializers/JsonEventSerializer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public function deserialize(
3737
string $eventClass,
3838
string $json,
3939
int $version,
40-
string $metadata = null
40+
?string $metadata = null
4141
): ShouldBeStored {
4242
return $this->serializer->deserialize($json, $eventClass, 'json');
4343
}

0 commit comments

Comments
 (0)