When activity changes has been emptied by pipes, discard it.

Author: felabrecque

src/Traits/LogsActivity.php

@@ -62,10 +62,6 @@ protected static function bootLogsActivity(): void
                     return;
                 }
 
-                if ($model->isLogEmpty($changes) && ! $model->activitylogOptions->submitEmptyLogs) {
-                    return;
-                }
-
                 // User can define a custom pipelines to mutate, add or remove from changes
                 // each pipe receives the event carrier bag with changes and the model in
                 // question every pipe should manipulate new and old attributes.
@@ -74,6 +70,10 @@ protected static function bootLogsActivity(): void
                     ->through(static::$changesPipes)
                     ->thenReturn();
 
+                if ($model->isLogEmpty($event->changes) && ! $model->activitylogOptions->submitEmptyLogs) {
+                    return;
+                }
+
                 // Actual logging
                 $logger = app(ActivityLogger::class)
                     ->useLog($logName)

tests/DetectsChangesTest.php

@@ -382,6 +382,50 @@ public function handle(EventLogBag $event, Closure $next): EventLogBag
     $this->assertEquals($expectedChanges, $this->getLastActivity()->changes()->toArray());
 });
 
+it('can block activity entry when pipe modification empties changes', function () {
+    $articleClass = new class() extends Article {
+        use LogsActivity;
+
+        public function getActivitylogOptions(): LogOptions
+        {
+            return LogOptions::defaults()
+                ->dontSubmitEmptyLogs()
+                ->logOnly(['name', 'text', 'user.name']);
+        }
+    };
+
+    $user = User::create([
+        'name' => 'user name',
+    ]);
+
+    $articleClass::addLogChange(new class() implements LoggablePipe {
+        public function handle(EventLogBag $event, Closure $next): EventLogBag
+        {
+            if ('updated' === $event->event) {
+                $event->changes = [
+                    'attributes' => [],
+                    'old' => [],
+                ];
+            }
+
+            return $next($event);
+        }
+    });
+
+    $article = $articleClass::create([
+        'name' => 'original name',
+        'text' => 'original text',
+        'user_id' => $user->id,
+    ]);
+
+    $article->name = 'updated name';
+    $article->text = 'updated text';
+    $article->save();
+
+    $this->assertEquals(1, Activity::query()->count(), 'Only the created event should be present');
+    $this->assertEquals('created', $this->getLastActivity()->event);
+});
+
 it('can store empty relation when creating a model', function () {
     $articleClass = new class() extends Article {
         use LogsActivity;