browsertime.run.timings.serverTimings not being written to InfluxDB the same way browsertime.run.timings.userTimings is

[sUBFUSC96]

Have you read the documentation?

• Yes, I've read the how to make a reproducable bug guide
• Yes, I've read the how to debug my script guide

URL

Cannot make repro as glitch.com / jsbin.com don't allow for custom headers

What are you trying to accomplish

At the moment I am trying to execute some sitespeed runs with the results pushed to our InfluxDB instance. We are in the works of setting up multiple values for the serverTimings. Our tested website already includes several serverTimings in the correct header, see:

The sitespeed run recognizes the header and pushes the results to our InfluxDB. Sadly those serverTimings are not pushed the same way our userTimings are, for example.

The userTimings are pushed in a way so that the _measurement field has the name of the timing:

The serverTimings however are pushed to the InfluxDB like this, with no way of knowing what name the value has. It is just an array index:

I am confident, that this is an oversight as I expected to have the correct names of the timings as the _measurement field as well. The way it is right now does not leave us with the possibility to write queries for our InfluxDB with consistent responses.

What browser did you use?

Chrome

How to reproduce

// Use metrics.list CLI parameter to check the output of which metrics are being pushed to InfluxDB
--metrics.list

// Use metrics.filter inside our config.json to measure serverTimings
"metrics": {
    "filter": [
      "browsertime.pageSummary.statistics.timings.serverTimings"
    ]
  }

// Check InfluxDB for entries regarding serverTiming

Log output

browsertime.run.timings.serverTimings.0.duration
browsertime.run.timings.serverTimings.1.duration
browsertime.run.timings.serverTimings.2.duration
browsertime.run.timings.serverTimings.3.duration
browsertime.run.timings.serverTimings.4.duration
browsertime.run.timings.serverTimings.5.duration
browsertime.run.timings.serverTimings.6.duration
browsertime.run.timings.serverTimings.7.duration
browsertime.run.timings.serverTimings.8.duration
browsertime.run.timings.serverTimings.9.duration
browsertime.run.timings.serverTimings.10.duration
browsertime.run.timings.serverTimings.11.duration
browsertime.run.timings.serverTimings.12.duration
browsertime.run.timings.serverTimings.13.duration
browsertime.run.timings.serverTimings.14.duration
browsertime.run.timings.serverTimings.15.duration
browsertime.run.timings.serverTimings.16.duration
browsertime.run.timings.serverTimings.17.duration
browsertime.run.timings.serverTimings.18.duration
browsertime.run.timings.serverTimings.19.duration
browsertime.run.timings.serverTimings.20.duration
browsertime.run.timings.serverTimings.21.duration
browsertime.run.timings.serverTimings.22.duration
browsertime.run.timings.serverTimings.23.duration
browsertime.run.timings.serverTimings.24.duration
browsertime.run.timings.serverTimings.25.duration
browsertime.run.timings.serverTimings.26.duration
browsertime.run.timings.serverTimings.27.duration
browsertime.run.timings.serverTimings.28.duration
browsertime.run.timings.serverTimings.29.duration
browsertime.run.timings.serverTimings.30.duration
browsertime.run.timings.serverTimings.31.duration
browsertime.run.timings.serverTimings.32.duration
browsertime.run.timings.serverTimings.33.duration
browsertime.run.timings.userTimings.marks.0.startTime
browsertime.run.timings.userTimings.marks.1.startTime
browsertime.run.timings.userTimings.marks.2.startTime
browsertime.run.timings.userTimings.marks.3.startTime
browsertime.run.timings.userTimings.marks.4.startTime
browsertime.run.timings.userTimings.marks.5.startTime
browsertime.run.timings.userTimings.marks.6.startTime
browsertime.run.timings.userTimings.marks.7.startTime
browsertime.run.timings.userTimings.marks.8.startTime
browsertime.run.timings.userTimings.marks.9.startTime
browsertime.run.timings.userTimings.marks.10.startTime
browsertime.run.timings.userTimings.marks.11.startTime
browsertime.run.timings.userTimings.marks.12.startTime
browsertime.run.timings.userTimings.marks.13.startTime
browsertime.run.timings.userTimings.marks.14.startTime
browsertime.run.timings.userTimings.marks.15.startTime
browsertime.run.timings.userTimings.marks.16.startTime
browsertime.run.timings.userTimings.marks.17.startTime
browsertime.run.timings.userTimings.marks.18.startTime
browsertime.run.timings.userTimings.marks.19.startTime
browsertime.run.timings.userTimings.marks.20.startTime
browsertime.run.timings.userTimings.measures.0.duration
browsertime.run.timings.userTimings.measures.0.startTime
browsertime.run.timings.userTimings.measures.1.duration
browsertime.run.timings.userTimings.measures.1.startTime
browsertime.run.timings.userTimings.measures.2.duration
browsertime.run.timings.userTimings.measures.2.startTime
browsertime.run.timings.userTimings.measures.3.duration
browsertime.run.timings.userTimings.measures.3.startTime
browsertime.run.timings.userTimings.measures.4.duration
browsertime.run.timings.userTimings.measures.4.startTime
browsertime.run.timings.userTimings.measures.5.duration
browsertime.run.timings.userTimings.measures.5.startTime
browsertime.run.timings.userTimings.measures.6.duration
browsertime.run.timings.userTimings.measures.6.startTime
browsertime.run.timings.userTimings.measures.7.duration
browsertime.run.timings.userTimings.measures.7.startTime
browsertime.run.timings.userTimings.measures.8.duration
browsertime.run.timings.userTimings.measures.8.startTime
browsertime.run.timings.userTimings.measures.9.duration
browsertime.run.timings.userTimings.measures.9.startTime
browsertime.run.timings.userTimings.measures.10.duration
browsertime.run.timings.userTimings.measures.10.startTime
browsertime.run.timings.userTimings.measures.11.duration
browsertime.run.timings.userTimings.measures.11.startTime

[soulgalore]

Hi @sUBFUSC96 yes I think you are correct, we don't have any special handling of server timings in the code, so that's why it breaks. The code for "converting" a metrics to a metric with tag isn't the most beautiful thing:
https://github.com/sitespeedio/plugin-influxdb/blob/main/lib/data-generator.js#L24-L38

That code also needs to take care of serverTimings. Would you mind to check if you could do a PR to fix it?

Thanks
Peter

[sUBFUSC96]

Hi @soulgalore I am looking into it and will be keeping you update here.

Thanks
Niklas