Skip to content

Commit 892d211

Browse files
committed
Remove duplicate assets from SignalShareExtension and consolidate resizable imagesets
- SignalShareExtension was embedding its own copy of Images.xcassets and Symbols.xcassets, duplicating assets already in the main app bundle - Use Bundle.app extension to load images from the containing app instead - Delete *-resizable imagesets (group, person, note, number, invite) which were byte-for-byte identical copies of their base imagesets with the same Contents.json - Update code references to use base imageset names instead of -resizable variants Reduces app bundle size by ~10MB.
1 parent 9ea0a9c commit 892d211

File tree

31 files changed

+40
-121
lines changed

31 files changed

+40
-121
lines changed

Signal.xcodeproj/project.pbxproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,6 @@
298298
3470C8822559B23F00F5847C /* CVUpdate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3470C8812559B23F00F5847C /* CVUpdate.swift */; };
299299
3471211025ED5F910037CD1F /* PaymentsReconciliationTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3471210E25ED5F850037CD1F /* PaymentsReconciliationTest.swift */; };
300300
347342F72548587900D440CD /* ConversationViewController+BottomBar.swift in Sources */ = {isa = PBXBuildFile; fileRef = 347342F62548587800D440CD /* ConversationViewController+BottomBar.swift */; };
301-
3478504C1FD7496D007B8332 /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = B66DBF4919D5BBC8006EA940 /* Images.xcassets */; };
302301
347850571FD86544007B8332 /* SAEFailedViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 347850561FD86544007B8332 /* SAEFailedViewController.swift */; };
303302
34798A8725AF965300EC89B4 /* ProfileBioViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 34798A8625AF965300EC89B4 /* ProfileBioViewController.swift */; };
304303
3479D6B226A762E200811069 /* ChatListViewController+Reminders.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3479D6B126A762E200811069 /* ChatListViewController+Reminders.swift */; };
@@ -1437,7 +1436,6 @@
14371436
766035A9286CE4CB00F6B71C /* MediaTopBar.swift in Sources */ = {isa = PBXBuildFile; fileRef = 766035A8286CE4CB00F6B71C /* MediaTopBar.swift */; };
14381437
76616C9D2A266A05005F7001 /* WindowManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = 76616C9C2A266A05005F7001 /* WindowManager.swift */; };
14391438
7665BC9D2A3A72910060279B /* Symbols.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 7665BC9C2A3A72910060279B /* Symbols.xcassets */; };
1440-
7665BC9E2A3A72910060279B /* Symbols.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 7665BC9C2A3A72910060279B /* Symbols.xcassets */; };
14411439
7666D54428331E1100A3BDB9 /* ImageEditorViewController+Draw.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7666D54328331E1100A3BDB9 /* ImageEditorViewController+Draw.swift */; };
14421440
7666D54628331E4800A3BDB9 /* ImageEditorViewController+Blur.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7666D54528331E4800A3BDB9 /* ImageEditorViewController+Blur.swift */; };
14431441
7666D54828331E6900A3BDB9 /* ImageEditorViewController+Text.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7666D54728331E6900A3BDB9 /* ImageEditorViewController+Text.swift */; };
@@ -15192,9 +15190,7 @@
1519215190
isa = PBXResourcesBuildPhase;
1519315191
buildActionMask = 2147483647;
1519415192
files = (
15195-
3478504C1FD7496D007B8332 /* Images.xcassets in Resources */,
1519615193
5010526B2BDB23F50097DDC5 /* PrivacyInfo.xcprivacy in Resources */,
15197-
7665BC9E2A3A72910060279B /* Symbols.xcassets in Resources */,
1519815194
);
1519915195
runOnlyForDeploymentPostprocessing = 0;
1520015196
};

Signal/ConversationView/Components/CVComponentThreadDetails.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,7 +1049,7 @@ extension CVComponentThreadDetails {
10491049

10501050
let membersAttributedText = NSAttributedString.composed(of: [
10511051
NSAttributedString.with(
1052-
image: UIImage(named: "group-resizable")!,
1052+
image: UIImage(named: "group")!,
10531053
font: Self.mutualGroupsFont
10541054
),
10551055
" ",
@@ -1199,7 +1199,7 @@ extension CVComponentThreadDetails {
11991199
detailsText: phoneNumberString,
12001200
mutualGroupsText: NSAttributedString.composed(of: [
12011201
NSAttributedString.with(
1202-
image: UIImage(named: "group-resizable")!,
1202+
image: UIImage(named: "group")!,
12031203
font: Self.mutualGroupsFont
12041204
),
12051205
" ",

Signal/Symbols.xcassets/group/group-resizable.imageset/Contents.json

Lines changed: 0 additions & 16 deletions
This file was deleted.
-3.45 KB
Binary file not shown.

Signal/Symbols.xcassets/invite/invite-resizable.imageset/Contents.json

Lines changed: 0 additions & 15 deletions
This file was deleted.
Binary file not shown.

Signal/Symbols.xcassets/note/note-resizable.imageset/Contents.json

Lines changed: 0 additions & 17 deletions
This file was deleted.
-4.54 KB
Binary file not shown.

Signal/Symbols.xcassets/number/number-resizable.imageset/Contents.json

Lines changed: 0 additions & 15 deletions
This file was deleted.
Binary file not shown.

0 commit comments

Comments
 (0)