Merge pull request #502 from saloonphp/fix/parse-url-with-underscores

Fix | URLHelper incorrectly URLs with underscores

Author: Sammyjo20

src/Helpers/URLHelper.php

@@ -44,6 +44,11 @@ public static function join(string $baseUrl, string $endpoint): string
      */
     public static function isValidUrl(string $url): bool
     {
+        // The following str_replace is used to get around an issue raised by PHP 8.4
+        // @see https://github.com/php/php-src/issues/17842
+
+        $url = str_replace('_', '-', $url);
+
         return ! empty(filter_var($url, FILTER_VALIDATE_URL));
     }
 

tests/Unit/URLHelperTest.php

@@ -15,6 +15,7 @@
     ['', 'https://google.com/search', 'https://google.com/search'],
     ['', 'google.com/search', '/google.com/search'],
     ['https://google.com', 'https://api.google.com/search', 'https://api.google.com/search'],
+    ['', 'https://example_underscores.com/search', 'https://example_underscores.com/search'],
 ]);
 
 test('the URL helper can parse a variety of query parameters', function (string $query, array $expected) {