Skip to content

Conversation

@phil-davis
Copy link
Contributor

Backport #726 to the 4.5 branch.

Specfically avoid the property name "0" crashes the parser with a 'LogicException: This code should not be reachable'
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.65%. Comparing base (d869496) to head (fa40f15).
⚠️ Report is 1 commits behind head on 4.5.

Additional details and impacted files
@@            Coverage Diff            @@
##                4.5     #738   +/-   ##
=========================================
  Coverage     98.65%   98.65%           
+ Complexity     1931     1893   -38     
=========================================
  Files            71       71           
  Lines          5296     5296           
=========================================
  Hits           5225     5225           
  Misses           71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phil-davis
Copy link
Contributor Author

For ancient PHP 7.1 and 7.2 php-cs-fixer reports:

Files that were not fixed due to errors reported during linting before fixing:
   1) /home/runner/work/vobject/vobject/tests/VObject/Component/VAvailabilityTest.php
   2) /home/runner/work/vobject/vobject/tests/VObject/Parser/XmlTest.php

The positioning of the comma directly after the "XML" end of section seems to not be valid.
I will remove that 2nd commit which is only code formatting.

@phil-davis phil-davis merged commit 2808636 into sabre-io:4.5 Dec 2, 2025
12 checks passed
@phil-davis phil-davis deleted the backport-726-to-4.5 branch December 2, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants