Avoid comment loop and do not post empty command comment when there are existing errors

Kobzol · Kobzol · commit 377fc59023a8 · 2025-11-17T16:56:33.000+01:00
diff --git a/site/src/request_handlers/github.rs b/site/src/request_handlers/github.rs
@@ -159,8 +159,8 @@ async fn handle_rust_timer(
         }
     }
 
-    if valid_build_cmds.is_empty() {
-        errors.push_str("@rust-timer command cannot be empty\n");
+    if valid_build_cmds.is_empty() && errors.is_empty() {
+        errors.push_str("Command cannot be empty\n");
     }
 
     if !errors.is_empty() {

Original file line number	Diff line number	Diff line change
`@@ -159,8 +159,8 @@ async fn handle_rust_timer(`
`159`	`159`	`}`
`160`	`160`	`}`
`161`	`161`
`162`		`- if valid_build_cmds.is_empty() {`
`163`		`- errors.push_str("@rust-timer command cannot be empty\n");`
	`162`	`+ if valid_build_cmds.is_empty() && errors.is_empty() {`
	`163`	`+ errors.push_str("Command cannot be empty\n");`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`if !errors.is_empty() {`