Migrate tests from xUnit to NUnit (#452)

* Migrate tests from xUnit to NUnit

Replaces xUnit with NUnit in test projects, updates test attributes and assertions accordingly, and adjusts package references. This unifies the test framework across the codebase and ensures compatibility with NUnit tooling.

* Update ci-build.yml

Author: ChrisPulman

.github/workflows/ci-build.yml

@@ -1,18 +1,21 @@
-name: Build
+name: Build
 
 on:
   push:
-    branches: [ main ]
-  pull_request:
-    branches: [ main ]
-
-env:
-  productNamespacePrefix: "Fusillade"
+    branches:
+      - main          # ✅ run on main
+  pull_request:        # (optional) run on PRs targeting any branch
+  
+# Needed so the reusable workflow can optionally delete the temp per-OS artifacts it creates.
+permissions:
+  contents: read
+  actions: write
 
 jobs:
   build:
     uses: reactiveui/actions-common/.github/workflows/workflow-common-setup-and-build.yml@main
     with:
       configuration: Release
       productNamespacePrefix: "Fusilade"
-      installWorkflows: false
+    secrets:
+      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

src/Directory.build.props

@@ -32,11 +32,9 @@
 	<ItemGroup Condition="'$(IsTestProject)' == 'true'">
 		<PackageReference Include="ReactiveUI.Testing" Version="21.*" />
 		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
-		<PackageReference Include="xunit" Version="2.9.3" />
-		<PackageReference Include="xunit.runner.console" Version="2.9.3" />
-		<PackageReference Include="xunit.runner.visualstudio" Version="3.1.4" />
-		<PackageReference Include="Xunit.StaFact" Version="1.2.69" />
-		<PackageReference Include="Verify.Xunit" Version="30.10.0" />
+		<PackageReference Include="NUnit" Version="4.4.0" />
+		<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
+		<PackageReference Include="Verify.NUnit" Version="30.10.0" />
 		<PackageReference Include="FluentAssertions" Version="8.8.0" />
 		<PackageReference Include="PublicApiGenerator" Version="11.4.6" />
 		<PackageReference Include="coverlet.msbuild" Version="6.0.4" PrivateAssets="All" />

src/Fusillade.Tests/API/ApiApprovalTests.cs

@@ -5,7 +5,7 @@
 
 using System.Diagnostics.CodeAnalysis;
 using System.Threading.Tasks;
-using Xunit;
+using NUnit.Framework;
 
 namespace Fusillade.APITests
 {
@@ -19,7 +19,7 @@ public class ApiApprovalTests
         /// Tests to make sure the akavache project is approved.
         /// </summary>
         /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
-        [Fact]
-        public Task FusilladeTests() => typeof(OfflineHttpMessageHandler).Assembly.CheckApproval(["Fusillade"]);
+        [Test]
+        public Task FusilladeTests() => typeof(OfflineHttpMessageHandler).Assembly.CheckApproval(new[] { "Fusillade" });
     }
 }

src/Fusillade.Tests/API/ApiExtensions.cs

@@ -8,8 +8,9 @@
 using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Threading.Tasks;
+using NUnit.Framework; // add for NUnit attributes if needed later
 using PublicApiGenerator;
-using VerifyXunit;
+using VerifyNUnit; // changed from VerifyXunit
 
 namespace Fusillade.APITests;
 

src/Fusillade.Tests/Http/HttpSchedulerCachingTests.cs

@@ -14,20 +14,21 @@
 using System.Threading.Tasks;
 using Akavache;
 using Akavache.SystemTextJson;
-using Xunit;
+using NUnit.Framework; // switched from xunit
 
 namespace Fusillade.Tests.Http
 {
     /// <summary>
     /// Checks to make sure that the http scheduler caches correctly.
     /// </summary>
+    [TestFixture]
     public class HttpSchedulerCachingTests
     {
         /// <summary>
         /// Checks to make sure that the caching functiosn are only called with content.
         /// </summary>
         /// <returns>A task to monitor the progress.</returns>
-        [Fact]
+        [Test]
         public async Task CachingFunctionShouldBeCalledWithContent()
         {
             var innerHandler = new TestHttpMessageHandler(_ =>
@@ -53,16 +54,16 @@ public async Task CachingFunctionShouldBeCalledWithContent()
             var client = new HttpClient(fixture);
             var str = await client.GetStringAsync(new Uri("http://lol/bar"));
 
-            Assert.Equal("foo", str);
-            Assert.Equal(1, contentResponses.Count);
-            Assert.Equal(3, contentResponses[0].Length);
+            Assert.That(str, Is.EqualTo("foo"));
+            Assert.That(contentResponses.Count, Is.EqualTo(1));
+            Assert.That(contentResponses[0].Length, Is.EqualTo(3));
         }
 
         /// <summary>
         /// Checks to make sure that the cache preserves the http headers.
         /// </summary>
         /// <returns>A task to monitor the progress.</returns>
-        [Fact]
+        [Test]
         public async Task CachingFunctionShouldPreserveHeaders()
         {
             var innerHandler = new TestHttpMessageHandler(_ =>
@@ -86,14 +87,14 @@ public async Task CachingFunctionShouldPreserveHeaders()
 
             var client = new HttpClient(fixture);
             var resp = await client.GetAsync(new Uri("http://lol/bar"));
-            Assert.Equal("\"worifjw\"", etagResponses[0]);
+            Assert.That(etagResponses[0], Is.EqualTo("\"worifjw\""));
         }
 
         /// <summary>
         /// Does a round trip integration test.
         /// </summary>
         /// <returns>A task to monitor the progress.</returns>
-        [Fact]
+        [Test]
         public async Task RoundTripIntegrationTest()
         {
             var aka = CacheDatabase.CreateBuilder().WithSerializerSystemTextJson().Build();
@@ -112,19 +113,18 @@ public async Task RoundTripIntegrationTest()
             var client = new HttpClient(cachingHandler);
             var origData = await client.GetStringAsync(new Uri("http://httpbin.org/get"));
 
-            Assert.True(origData.Contains("origin"));
+            Assert.That(origData.Contains("origin"), Is.True);
 
-            // Some Akavache cache implementations expose a single key, not a collection.
             var singleKey = await cache.GetAllKeys();
-            Assert.False(string.IsNullOrEmpty(singleKey));
-            Assert.StartsWith("HttpSchedulerCache_", singleKey, StringComparison.Ordinal);
+            Assert.That(string.IsNullOrEmpty(singleKey), Is.False);
+            Assert.That(singleKey.StartsWith("HttpSchedulerCache_", StringComparison.Ordinal), Is.True);
 
             var offlineHandler = new OfflineHttpMessageHandler(async (rq, key, ct) => await cache.Get(key));
 
             client = new HttpClient(offlineHandler);
             var newData = await client.GetStringAsync(new Uri("http://httpbin.org/get"));
 
-            Assert.Equal(origData, newData);
+            Assert.That(origData, Is.EqualTo(newData));
 
             bool shouldDie = true;
             try
@@ -137,7 +137,7 @@ public async Task RoundTripIntegrationTest()
                 Console.WriteLine(ex);
             }
 
-            Assert.False(shouldDie);
+            Assert.That(shouldDie, Is.False);
         }
 
         /// <summary>
@@ -146,14 +146,13 @@ public async Task RoundTripIntegrationTest()
         /// <param name="method">The name of the method.</param>
         /// <param name="shouldCache">If it should be cached or not.</param>
         /// <returns>A task to monitor the progress.</returns>
-        [Theory]
-        [InlineData("GET", true)]
-        [InlineData("HEAD", true)]
-        [InlineData("OPTIONS", true)]
-        [InlineData("POST", false)]
-        [InlineData("DELETE", false)]
-        [InlineData("PUT", false)]
-        [InlineData("WHATEVER", false)]
+        [TestCase("GET", true)]
+        [TestCase("HEAD", true)]
+        [TestCase("OPTIONS", true)]
+        [TestCase("POST", false)]
+        [TestCase("DELETE", false)]
+        [TestCase("PUT", false)]
+        [TestCase("WHATEVER", false)]
         public async Task OnlyCacheRelevantMethods(string method, bool shouldCache)
         {
             var innerHandler = new TestHttpMessageHandler(_ =>
@@ -178,7 +177,7 @@ public async Task OnlyCacheRelevantMethods(string method, bool shouldCache)
             var request = new HttpRequestMessage(new(method), "http://lol/bar");
             await client.SendAsync(request);
 
-            Assert.Equal(shouldCache, cached);
+            Assert.That(cached, Is.EqualTo(shouldCache));
         }
     }
 }