Do not check for SSL with secure option #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The W3 Secure Contexts specification defines additional contexts to be potentially secure beyond HTTPS, such as localhost, 127.0.0.1, and *.localhost. Therefore, by limiting secure cookies to only SSL, we are restricting session uses in additional valid contexts (which is particularly important because setting SameSite=None, which is required by cross-domain iframes, is only doable with the Secure flag). Backwards-compatibility wise this should be safe because Secure cookies were never returned outside of SSL, and now we will start to. Furthermore, if a Secure cookie is returned over a non-Secure Context, browser automatically discard them. https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts
Author
|
It would be important for a security minded person to double check this pull request. |
Author
|
If anyone was looking to blame the code to understand why it behaves like this: rack/rack@4defbe5#diff-225166a61eb70a7b8bf59f3c3283e0d6c1e95b02734ad800657117676a6d0e1bR242 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The W3 Secure Contexts specification defines additional contexts to be potentially secure beyond HTTPS, such as localhost, 127.0.0.1, and *.localhost. Therefore, by limiting secure cookies to only SSL, we are restricting session uses in additional valid contexts (which is particularly important because setting SameSite=None, which is required by cross-domain iframes, is only doable with the Secure flag).
Backwards-compatibility wise this should be safe because Secure cookies were never returned outside of SSL, and now we will start to. Furthermore, if a Secure cookie is returned over a non-Secure Context, browser automatically discard them.
https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts