Skip to content

Conversation

@twak
Copy link

@twak twak commented Sep 25, 2025

https://eolp.jaxa.jp/GCOM-W_AMSR2_L1R_TB.html

Adds a missing downstream layer from Jaxa's AMSR2 satellite

  • Closes
  • Tests added - no really new code
  • Fully documented - none of the existing amsr stuff is documented...?
  • Add your name to AUTHORS.md if not there already

@djhoese
Copy link
Member

djhoese commented Sep 25, 2025

The referenced URL mentions this data is a resampled version of the L1B data. It sounds like it is resampled to the 89GHz A channel, not a uniform grid. Does that sound right? So you still have a "swath" of pixels, right?

@twak
Copy link
Author

twak commented Sep 25, 2025

Yes, it is a swath, very similar to l1b, but with some brightness and alignment corrections.

@strandgren strandgren closed this Sep 25, 2025
@strandgren strandgren reopened this Sep 25, 2025
@strandgren
Copy link
Collaborator

Sorry for closing, accidentally touched the wrong part of the screen..

@twak
Copy link
Author

twak commented Dec 1, 2025

I also have code for another modis l2 product - mod29 - let me know if you want a pr!

@djhoese djhoese changed the title add support for amsr2 l1r Add AMSR2 L1R (amsr2_l1r) reader Dec 1, 2025
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the python code doesn't do anything unique feel free to point to the same Python class as L1B from the YAML configuration and delete the new python module you created here.

This PR will also need a test module though (perhaps using the L1B tests as a parent class?) to test that the structure of these L1R files is read-able by Satpy.

@djhoese
Copy link
Member

djhoese commented Dec 1, 2025

Looks like you'll also need to fix the issues that pre-commit is talking about. You could also have it do that locally when you make a commit:

pip install pre-commit
pre-commit install

then every commit after that will run our pre-commit checks before letting you successfully making a commit.

For the MODIS changes, feel free to make a PR to update the modis_l2 reader with the new file type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants