-
Notifications
You must be signed in to change notification settings - Fork 320
Add AMSR2 L1R (amsr2_l1r) reader #3241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The referenced URL mentions this data is a resampled version of the L1B data. It sounds like it is resampled to the 89GHz A channel, not a uniform grid. Does that sound right? So you still have a "swath" of pixels, right? |
|
Yes, it is a swath, very similar to l1b, but with some brightness and alignment corrections. |
|
Sorry for closing, accidentally touched the wrong part of the screen.. |
|
I also have code for another modis l2 product - mod29 - let me know if you want a pr! |
djhoese
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the python code doesn't do anything unique feel free to point to the same Python class as L1B from the YAML configuration and delete the new python module you created here.
This PR will also need a test module though (perhaps using the L1B tests as a parent class?) to test that the structure of these L1R files is read-able by Satpy.
|
Looks like you'll also need to fix the issues that pre-commit is talking about. You could also have it do that locally when you make a commit: then every commit after that will run our pre-commit checks before letting you successfully making a commit. For the MODIS changes, feel free to make a PR to update the modis_l2 reader with the new file type. |
https://eolp.jaxa.jp/GCOM-W_AMSR2_L1R_TB.html
Adds a missing downstream layer from Jaxa's AMSR2 satellite
AUTHORS.mdif not there already