Make sync and async requests with the same client

[osintalex]

Is there a recommended way to reuse the same client object to make both sync and async requests? I'm writing a client library for something that needs to support making async and sync requests. I'd prefer to use one client library for this to improve performance and reduce overhead, i.e.:

from httpx import AsyncClient


client = AsyncClient()

class MyClientLib:
    def __init__(self, client: AsyncClient):
        self.client = client 
    
    # works fine 
    async def make_async_request(self):
        return await self.client.get("some url")
    
    # does not work since returns coroutine
    # would prefer to make a get request here without
    # instantiating a new sync Client object
    def make_sync_request(self):
        return self.client.get("some url")
    
    def __exit__(self):
        self.client.close()

Or am I overcomplicating this? Would this actually be fine:

client = AsyncClient()
sync_client = Client()
class MyClientLib:
    def __init__(self, client: AsyncClient, sync_client: Client):
        self.client = client 
        self.sync_client = sync_client

[dogancanbakir]

This discussion closed automatically due to inactivity. Feel free to reopen or start new if still relevant.