-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Adding translation in pt-BR for KeyboardShortcuts.CodeEditing.RenameVariable locale key
#3712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…Variable` locale key
|
@raclim, this is exactly the kind ot situation discussed in #3666, where a new feature (or bug fix) in introduced into the editor, bringing along with it new localization keys, which remain untranslated for all locales besides the default |
|
BTW, I couldn't find a way to use the "rename variable" shortcut in my Macbook Pro. I have tried all kinds of Fn, Ctrl, Option and Command combinations with F2. Nothing worked. |
…rtcuts-code-editing-rename-variable-locale-key
…rtcuts-code-editing-rename-variable-locale-key
…rtcuts-code-editing-rename-variable-locale-key
…rtcuts-code-editing-rename-variable-locale-key
…rtcuts-code-editing-rename-variable-locale-key
…rtcuts-code-editing-rename-variable-locale-key
…rtcuts-code-editing-rename-variable-locale-key
raclim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this!
@raclim, I could not find a way to use this new feature in my Macbook Pro M3. Any help will be strongly appreciated. |
|
@cassiano I think to use the "rename variable" function within the editor, you will need to highlight the variable you wish to rename and then use the "Ctrl + F2" command (in the video below). I believe this was intended to be mirrored after the functionality within VS Code. It is a bit tricky to figure out, so there probably needs to be further instruction or an additional Menu Option to activate it more easily. rename_variable.mov |
@raclim, I have a Macbook Pro with the M3 chip and the suggested keys DO NOT work as expected. In fact nothing happens when they are pressed after selecting the variable name. I tried Ctrl+F2, Fn+F2, Ctrl+Fn+F2 etc, with no success. Have you tried it in a Macbook yourself? |
|
@cassiano Yes I am on a Macbook—albeit a bit older model! I do have my function keys as the standards one by default within my Keyboard Settings (pictured below), but I believe it should work if you use the Globe key as well (i.e Globe key + Ctrl + F2). This probably needs to be updated within the Keyboard Shortcuts modal so it's clearer!
|
|
@raclim, I have been using the way you suggested, but it still doesn't work. I am using the keyboard default settings for my Mac, so this must be a bug on p5.js's editor side. |

Fixes #3711
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123