Release/v1.14.0 #19
Release/v1.14.0 #19
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| klines_type: HistoricalKlinesType = HistoricalKlinesType.SPOT, | ||
| ) -> list[KlineMarketTicker]: | ||
| """获取历史行情数据.""" | ||
| ) -> list["SpotKlineTicker"] | list["FuturesKlineTicker"]: |
There was a problem hiding this comment.
Bug: API Method Signature Change Causes Errors
The get_historical_klines method signature changed, making interval a required parameter and shifting its position. This breaks existing calls using positional arguments, as end_time may now be incorrectly passed as interval, leading to runtime errors.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| self, | ||
| symbol: str, | ||
| start_time: str | datetime, | ||
| interval: Freq, | ||
| end_time: str | datetime | None = None, | ||
| interval: Freq = Freq.h1, | ||
| klines_type: HistoricalKlinesType = HistoricalKlinesType.SPOT, |
There was a problem hiding this comment.
The new signature of MarketDataService.get_historical_klines moves interval ahead of end_time but still accepts both positionally. Any existing code that called the API with the previous order—get_historical_klines(symbol, start, end, interval)—will now pass a string (the former end_time) where a Freq is expected, causing an AttributeError when .value is accessed. This is a silent backward‑incompatible change for a public method and will fail at runtime for consumers that relied on the old positional order. Consider preserving the original parameter order or making the new parameters keyword-only to avoid unexpected breakages.
Useful? React with 👍 / 👎.
No description provided.