fix: Invalid conversion from non-bit numpy bools (#24312)

Author: orlp

crates/polars-python/src/series/construction.rs

@@ -3,7 +3,7 @@ use std::borrow::Cow;
 use arrow::array::Array;
 use arrow::bitmap::BitmapBuilder;
 use arrow::types::NativeType;
-use numpy::{Element, PyArray1, PyArrayMethods};
+use numpy::{Element, PyArray1, PyArrayMethods, PyUntypedArrayMethods};
 use polars_core::prelude::*;
 use polars_core::utils::CustomIterTools;
 use pyo3::exceptions::{PyTypeError, PyValueError};
@@ -58,8 +58,13 @@ impl PySeries {
         _strict: bool,
     ) -> PyResult<Self> {
         let array = array.readonly();
-        let vals = array.as_slice().unwrap();
-        py.enter_polars_series(|| Ok(Series::new(name.into(), vals)))
+
+        // We use raw ptr methods to read this as a u8 slice to work around PyO3/rust-numpy#509.
+        assert!(array.is_contiguous());
+        let data_ptr = array.data().cast::<u8>();
+        let data_len = array.len();
+        let vals = unsafe { core::slice::from_raw_parts(data_ptr, data_len) };
+        py.enter_polars_series(|| Series::new(name.into(), vals).cast(&DataType::Boolean))
     }
 
     #[staticmethod]

py-polars/tests/unit/interop/numpy/test_numpy.py

@@ -5,6 +5,7 @@
 from numpy.testing import assert_array_equal
 
 import polars as pl
+from polars.testing import assert_series_equal
 
 
 @pytest.fixture(
@@ -100,3 +101,8 @@ def test_init_from_numpy_values(np_dtype_cls: Any, expected_pl_dtype: Any) -> No
     # test init from raw numpy values (vs arrays)
     s = pl.Series("n", [np_dtype_cls(0), np_dtype_cls(4), np_dtype_cls(8)])
     assert s.dtype == expected_pl_dtype
+
+
+def test_from_numpy_nonbit_bools_24296() -> None:
+    a = np.array([24, 15, 32, 1, 0], dtype=np.uint8).view(bool)
+    assert_series_equal(pl.Series(a), pl.Series([True, True, True, True, False]))