Skip to content

feat: more safe commands #7728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jif-oai wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −1
Open

feat: more safe commands #7728

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fef904
feat: more safe commands
jif-oai Dec 8, 2025
7bc0a86
Update is_safe_command.rs
jif-oai Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion codex-rs/core/src/command_safety/is_safe_command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,19 +49,35 @@ fn is_safe_to_call_with_exec(command: &[String]) -> bool {
{
#[rustfmt::skip]
Some(
"base64" |
Copy link
Contributor

@voctory voctory Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to specify an output file for base64 with the -o flag. Would lead to an unintended write, assuming safe commands are supposed to be read-only

e.g. base64 -d -o /tmp/x payload bypasses approval even though it mutates the filesystem

BSD docs: https://ss64.com/mac/base64.html

"cat" |
"cd" |
"cut" |
"echo" |
"env" |
"expr" |
"false" |
"grep" |
"head" |
"id" |
"ls" |
"nl" |
"numfmt" |
Copy link
Collaborator

@bolinfest bolinfest Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Linux only? I don't see this on my Mac.

"paste" |
"pwd" |
"rev" |
"seq" |
"stat" |
"tac" |
Copy link
Collaborator

@bolinfest bolinfest Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not on Mac.

For the ones that are not natively in [root-owned] /usr/bin on macOS, let's only add them to the list for Linux.

Admittedly, on both Mac or Linux, someone could inject their own version of stat into the $PATH, but the case where it's shadowing something on $PATH is more sus than when it doesn't exist on the $PATH in the first place (e.g., tac).

"tail" |
"tr" |
"true" |
"uname" |
"uniq" |
"wc" |
"which") => {
"which" |
"whoami" |
"yes") => {
true
},

Expand Down
Loading