Skip to content

[latest] Callback load #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
logoutdhaval wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[latest] Callback load #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0df58cd
[PHEE-617] Getting multiple callbacks on single batch transaction API…
logoutdhaval Mar 12, 2024
1606c18
[latest] error handle
logoutdhaval Mar 13, 2024
24996d4
logger
logoutdhaval Mar 13, 2024
17f196a
logger
logoutdhaval Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/org/mifos/processor/bulk/camel/routes/BatchAggregateRoute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ public void configure() throws Exception {
}

exchange.setProperty(COMPLETION_RATE, percentage);

producerTemplate.send(RouteId.SEND_CALLBACK.getValue(), exchange);
}).otherwise().log(LoggingLevel.ERROR, "Batch aggregate request unsuccessful").process(exchange -> {
exchange.setProperty(BATCH_STATUS_FAILED, true);
exchange.setProperty(ERROR_DESCRIPTION, exchange.getIn().getBody(String.class));
Expand Down
23 changes: 13 additions & 10 deletions src/main/java/org/mifos/processor/bulk/zeebe/worker/AggregateWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.ERROR_CODE;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.ERROR_DESCRIPTION;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.MAX_CALLBACK_RETRY;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.MAX_STATUS_RETRY;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.PHASES;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.PHASE_COUNT;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.RETRY;
Expand Down Expand Up @@ -47,19 +48,21 @@ public void setup() {
sendToCamelRoute(RouteId.BATCH_AGGREGATE, exchange);

Boolean batchStatusFailed = exchange.getProperty(BATCH_STATUS_FAILED, Boolean.class);
if (batchStatusFailed == null || !batchStatusFailed) {
if (exchange.getException() != null && exchange.getException().getMessage() != null
&& exchange.getException().getMessage().contains("404")) {
logger.error("An error occurred, retrying");
successRate = 0;
} else {
successRate = exchange.getProperty(COMPLETION_RATE, Long.class).intValue();
}
} else {
// if (batchStatusFailed == null || !batchStatusFailed) {
if (exchange.getException() != null && exchange.getException().getMessage() != null
&& exchange.getException().getMessage().contains("404")) {
logger.error("An error occurred, retrying");
successRate = 0;
variables.put(ERROR_CODE, exchange.getProperty(ERROR_CODE));
variables.put(ERROR_DESCRIPTION, exchange.getProperty(ERROR_DESCRIPTION));
logger.info("Error: {}, {}", variables.get(ERROR_CODE), variables.get(ERROR_DESCRIPTION));
logger.info("Retry: {} , Error cause: {}, message: {}",retry, exchange.getException().getCause(), exchange.getException().getMessage());
} else {
logger.info("BATCH SUCCESS retry: {} , and maxRetry: {}",retry,variables.get(MAX_STATUS_RETRY));
successRate = exchange.getProperty(COMPLETION_RATE, Long.class).intValue();
}
// } else {

// }

variables.put(COMPLETION_RATE, successRate);
variables.put(RETRY, ++retry);
Expand Down
14 changes: 13 additions & 1 deletion src/main/java/org/mifos/processor/bulk/zeebe/worker/SendCallbackWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
package org.mifos.processor.bulk.zeebe.worker;

import static org.mifos.processor.bulk.camel.config.CamelProperties.CALLBACK_RESPONSE_CODE;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.BATCH_ID;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.CALLBACK;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.CALLBACK_RETRY;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.CALLBACK_SUCCESS;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.CLIENT_CORRELATION_ID;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.COMPLETION_RATE;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.COMPLETION_THRESHOLD;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.ERROR_CODE;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.ERROR_DESCRIPTION;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.MAX_CALLBACK_RETRY;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.MAX_STATUS_RETRY;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.PHASES;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.PHASE_COUNT;
import static org.mifos.processor.bulk.zeebe.ZeebeVariables.RETRY;

import java.util.Map;
import org.apache.camel.Exchange;
Expand Down Expand Up @@ -41,7 +45,15 @@ public void setup() {
exchange.setProperty(COMPLETION_RATE, variables.get(COMPLETION_RATE));
exchange.setProperty(PHASES, variables.get(PHASES));
exchange.setProperty(PHASE_COUNT, variables.get(PHASE_COUNT));
sendToCamelRoute(RouteId.SEND_CALLBACK, exchange);
exchange.setProperty(BATCH_ID, variables.get(BATCH_ID));
exchange.setProperty(CLIENT_CORRELATION_ID, variables.get(CLIENT_CORRELATION_ID));
Integer maxRetry = Integer.parseInt(variables.get(MAX_STATUS_RETRY).toString());
Integer completionRate = Integer.parseInt(variables.get(COMPLETION_RATE).toString());
Integer completionThreshold = Integer.parseInt(variables.get(COMPLETION_THRESHOLD).toString());
Integer statusRetry = Integer.parseInt(variables.get(RETRY).toString());
if (statusRetry >= maxRetry || completionRate >= completionThreshold) {
sendToCamelRoute(RouteId.SEND_CALLBACK, exchange);
}
}
Boolean callbackSuccess = exchange.getProperty(CALLBACK_SUCCESS, Boolean.class);
if (callbackSuccess == null || !callbackSuccess) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/application.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ config:
completion-threshold-check:
enable: false
completion-threshold: 95 # in percentage
max-retry: 15 #can be as high as 30
max-retry: 3 #can be as high as 30
delay: 2 # in seconds
deduplication:
enabled: true
Expand Down