feat!: cleanup evaluator interface (#1793)

depends: #1792 for fixing build issues

---------

Signed-off-by: Simon Schrottner <[email protected]>

Author: aepfli

core/pkg/evaluator/ievaluator.go

@@ -34,8 +34,7 @@ func NewAnyValue(
 IEvaluator is an extension of IResolver, allowing storage updates and retrievals
 */
 type IEvaluator interface {
-	GetState() (string, error)
-	SetState(payload sync.DataSync) (map[string]interface{}, bool, error)
+	SetState(payload sync.DataSync) error
 	IResolver
 }
 

core/pkg/evaluator/json.go

@@ -117,15 +117,7 @@ func NewJSON(logger *logger.Logger, s store.IStore, opts ...JSONEvaluatorOption)
 	return &ev
 }
 
-func (je *JSON) GetState() (string, error) {
-	s, err := je.store.String()
-	if err != nil {
-		return "", fmt.Errorf("unable to fetch evaluator state: %w", err)
-	}
-	return s, nil
-}
-
-func (je *JSON) SetState(payload sync.DataSync) (map[string]interface{}, bool, error) {
+func (je *JSON) SetState(payload sync.DataSync) error {
 	_, span := je.jsonEvalTracer.Start(
 		context.Background(),
 		"flagSync",
@@ -138,18 +130,12 @@ func (je *JSON) SetState(payload sync.DataSync) (map[string]interface{}, bool, e
 	if err != nil {
 		span.SetStatus(codes.Error, "flagSync error")
 		span.RecordError(err)
-		return nil, false, err
+		return err
 	}
 
-	var events map[string]interface{}
-	var reSync bool
-
-	events, reSync = je.store.Update(payload.Source, definition.Flags, definition.Metadata)
+	je.store.Update(payload.Source, definition.Flags, definition.Metadata)
 
-	// Number of events correlates to the number of flags changed through this sync, record it
-	span.SetAttributes(attribute.Int("feature_flag.change_count", len(events)))
-
-	return events, reSync, nil
+	return nil
 }
 
 // Resolver implementation for flagd flags. This resolver should be kept reusable, hence must interact with interfaces.