Skip to content

Conversation

@cschuijt
Copy link

@cschuijt cschuijt commented Feb 1, 2026

In certain cases, the Insulin dialog goes yellow and only allows entering "record-only" boluses, as implemented in #3254. Before 3.4.0.0/the running mode rework of loop status, these cases were limited to when there was no pump ready to run a bolus. With the rework, the condition was mistakenly changed from "is the pump suspended" to "is the loop suspended", which is why 3.4.0.0 will let you set basal rates but will not let you bolus as long as the loop is suspended: it's perfectly possible behind the scenes, but the insulin dialog will not allow it. This PR restores the 3.3.2.1 behavior, showing the correct insulin dialog when the loop is suspended but the pump is available.

As the other uses for RM's isSuspended() function do intentionally look at all loop suspension reasons, I added a separate function called isPumpSuspended() and use that to determine whether pump-boluses should be allowed. This way, pump suspension/disconnection should still lead to the yellow insulin dialog, but loop suspension should not prevent boluses anymore.

Tested with Omnipod Dash, confirmed the insulin dialog shows the right version in the following cases:

  • No pod active (record-only)
  • Active pod, pump disconnected (record-only)
  • Loop suspended (regular, on 3.4.0.0 this is record-only)
  • Loop enabled (regular)
  • Loop disabled (regular)

PS: this is my first time contributing to this repo, so if this is the wrong place/way to make this happen, let me know and I'll do my best to accommodate!

Fixes #4468, fixes #4517

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2026

@MilosKozak MilosKozak merged commit 85caedc into nightscout:dev Feb 2, 2026
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants