Deprecated constants used in newer Mac SDKs

[mrpapersonic]

In the Monterey SDK and newer, all constants using "Master" were renamed, marked deprecated, and print an annoying warning message on each build.

Fortunately this is an easy fix, and boils down to doing find/replace kAudioObjectPropertyElementMaster with kAudioObjectPropertyElementMain and adding to the top of each affected file:

#if MAC_OS_X_VERSION_MAX_ALLOWED < 120000
# define kAudioObjectPropertyElementMain kAudioObjectPropertyElementMaster
#endif

to retain compatibility with older SDKs.

[joevt]

If kAudioObjectPropertyElementMain is linked in a binary then doesn't that mean the binary can no longer be used in an earlier version of macOS that doesn't have kAudioObjectPropertyElementMain?

[mrpapersonic]

If kAudioObjectPropertyElementMain is linked in a binary then doesn't that mean the binary can no longer be used in an earlier version of macOS that doesn't have kAudioObjectPropertyElementMain?

It's an enum constant, either way the final binary will be identical. It's just an annoying warning that clogs up the terminal output.

[joevt]

It's an enum constant, either way the final binary will be identical. It's just an annoying warning that clogs up the terminal output.

Right. It's an enum so it won't get linked. Preprocessing cubeb_audiounit.cpp makes it easier to see:

# 201 "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/System/Library/Frameworks/CoreAudio.framework/Headers/AudioHardwareBase.h" 3
enum __attribute__((enum_extensibility(open))) : AudioObjectPropertyScope
{
    kAudioObjectPropertyScopeGlobal = 'glob',
    kAudioObjectPropertyScopeInput = 'inpt',
    kAudioObjectPropertyScopeOutput = 'outp',
    kAudioObjectPropertyScopePlayThrough = 'ptru',
    kAudioObjectPropertyElementMain = 0,
    kAudioObjectPropertyElementMaster __attribute__((availability(macos,introduced=10.0,deprecated=12.0,replacement="kAudioObjectPropertyElementMain"))) __attribute__((availability(ios,introduced=2.0,deprecated=15.0,replacement="kAudioObjectPropertyElementMain"))) __attribute__((availability(watchos,introduced=1.0,deprecated=8.0,replacement="kAudioObjectPropertyElementMain"))) __attribute__((availability(tvos,introduced=9.0,deprecated=15.0,replacement="kAudioObjectPropertyElementMain"))) = kAudioObjectPropertyElementMain
};

I brought this up since there are some objects in the macOS SDKs that were renamed from Master that are not enums but I don't think cubeb uses any of those.