fix(security): use random_int instead of rand (#7819)

Author: asbiin

app/Console/Commands/Local/SetupDummyAccount.php

@@ -140,13 +140,13 @@ private function createVaults(): void
     {
         $this->info('☐ Create vaults');
 
-        for ($i = 0; $i < rand(3, 5); $i++) {
+        for ($i = 0; $i < random_int(3, 5); $i++) {
             (new CreateVault)->execute([
                 'account_id' => $this->firstUser->account_id,
                 'author_id' => $this->firstUser->id,
                 'type' => Vault::TYPE_PERSONAL,
                 'name' => $this->faker->firstName,
-                'description' => rand(1, 2) == 1 ? $this->faker->sentence() : null,
+                'description' => random_int(1, 2) == 1 ? $this->faker->sentence() : null,
             ]);
         }
     }
@@ -160,7 +160,7 @@ private function createContacts(): void
                 ->where('internal_type', ContactImportantDate::TYPE_BIRTHDATE)
                 ->first();
 
-            for ($i = 0; $i < rand(2, 13); $i++) {
+            for ($i = 0; $i < random_int(2, 13); $i++) {
                 $date = $this->faker->dateTimeThisCentury();
                 $birthDate = Carbon::parse($date);
 
@@ -170,7 +170,7 @@ private function createContacts(): void
                     'vault_id' => $vault->id,
                     'first_name' => $this->faker->firstName(),
                     'last_name' => $this->faker->lastName(),
-                    'middle_name' => rand(1, 2) == 1 ? $this->faker->lastName() : null,
+                    'middle_name' => random_int(1, 2) == 1 ? $this->faker->lastName() : null,
                     'nickname' => null,
                     'maiden_name' => null,
                     'listed' => true,
@@ -184,7 +184,7 @@ private function createContacts(): void
                     'label' => 'Birthdate',
                     'day' => $birthDate->day,
                     'month' => $birthDate->month,
-                    'year' => rand(1, 2) == 1 ? $birthDate->year : null,
+                    'year' => random_int(1, 2) == 1 ? $birthDate->year : null,
                     'contact_important_date_type_id' => $birthDateType->id,
                 ]);
             }
@@ -196,8 +196,8 @@ private function createGroups(): void
         $this->info('☐ Create groups');
 
         foreach (Vault::all() as $vault) {
-            for ($i = 0; $i < rand(2, 5); $i++) {
-                $groupType = rand(1, 2) == 1 ? $this->firstUser->account->groupTypes->random() : null;
+            for ($i = 0; $i < random_int(2, 5); $i++) {
+                $groupType = random_int(1, 2) == 1 ? $this->firstUser->account->groupTypes->random() : null;
                 $group = (new CreateGroup)->execute([
                     'account_id' => $this->firstUser->account_id,
                     'vault_id' => $vault->id,
@@ -209,11 +209,11 @@ private function createGroups(): void
                 // Add random contacts to the group
                 $contacts = Contact::where('vault_id', $vault->id)
                     ->inRandomOrder()
-                    ->take(rand(1, 5))
+                    ->take(random_int(1, 5))
                     ->get();
 
                 foreach ($contacts as $contact) {
-                    $groupTypeRoles = $groupType !== null && rand(1, 2) == 1 ? $groupType->groupTypeRoles : null;
+                    $groupTypeRoles = $groupType !== null && random_int(1, 2) == 1 ? $groupType->groupTypeRoles : null;
                     if ($groupTypeRoles !== null && $groupTypeRoles->isNotEmpty()) {
                         $role = $groupTypeRoles->random();
                     } else {
@@ -244,7 +244,7 @@ private function createNotes(): void
                     'author_id' => $this->firstUser->id,
                     'vault_id' => $contact->vault_id,
                     'contact_id' => $contact->id,
-                    'title' => rand(1, 2) == 1 ? $this->faker->sentence(rand(3, 6)) : null,
+                    'title' => random_int(1, 2) == 1 ? $this->faker->sentence(random_int(3, 6)) : null,
                     'body' => $this->faker->paragraph(),
                 ]);
             }
@@ -262,7 +262,7 @@ private function createTasks(): void
                     'author_id' => $this->firstUser->id,
                     'vault_id' => $contact->vault_id,
                     'contact_id' => $contact->id,
-                    'label' => $this->faker->sentence(rand(3, 6)),
+                    'label' => $this->faker->sentence(random_int(3, 6)),
                     'description' => null,
                 ]);
             }
@@ -281,7 +281,7 @@ private function createGoals(): void
         ]);
 
         foreach (Contact::all() as $contact) {
-            foreach ($goals->take(rand(1, 4)) as $goal) {
+            foreach ($goals->take(random_int(1, 4)) as $goal) {
                 $goal = (new CreateGoal)->execute([
                     'account_id' => $this->firstUser->account_id,
                     'author_id' => $this->firstUser->id,
@@ -292,8 +292,8 @@ private function createGoals(): void
 
                 for ($i = 0; $i < 4; $i++) {
                     $date = Carbon::now()->subYears(2);
-                    for ($j = 0; $j < rand(1, 20); $j++) {
-                        $date = $date->addDays(rand(1, 3));
+                    for ($j = 0; $j < random_int(1, 20); $j++) {
+                        $date = $date->addDays(random_int(1, 3));
 
                         try {
                             (new ToggleStreak)->execute([
@@ -325,16 +325,16 @@ private function createJournals(): void
         ]);
 
         foreach (Vault::all() as $vault) {
-            foreach ($journals->take(rand(1, 4)) as $journal) {
+            foreach ($journals->take(random_int(1, 4)) as $journal) {
                 $journal = (new CreateJournal)->execute([
                     'account_id' => $this->firstUser->account_id,
                     'author_id' => $this->firstUser->id,
                     'vault_id' => $vault->id,
                     'name' => $journal,
-                    'description' => rand(1, 2) == 1 ? $this->faker->sentence() : null,
+                    'description' => random_int(1, 2) == 1 ? $this->faker->sentence() : null,
                 ]);
 
-                for ($j = 0; $j < rand(1, 20); $j++) {
+                for ($j = 0; $j < random_int(1, 20); $j++) {
                     (new CreatePost)->execute([
                         'account_id' => $this->firstUser->account_id,
                         'author_id' => $this->firstUser->id,

database/factories/GenderFactory.php

@@ -23,7 +23,7 @@ public function definition()
         return [
             'account_id' => Account::factory(),
             'name' => $this->faker->name(),
-            'type' => Gender::LIST[rand(0, 4)],
+            'type' => Gender::LIST[random_int(0, 4)],
         ];
     }
 }