Swap RS publish to ordinary pool using service connection (#1855) (#1859)

Author: dagood

eng/pipeline/stages/builders-to-stages.yml

@@ -83,10 +83,15 @@ stages:
 
   - ${{ if eq(parameters.publish, true) }}:
     - ${{ if parameters.ctx['GoPublishReleaseStudio'] }}:
-      - template: public-publish-stages.yml
+      - template: pool.yml
         parameters:
           ctx: ${{ parameters.ctx }}
-          publishExistingRunID: ${{ parameters.publishExistingRunID }}
+          inner:
+            template: public-publish-stages.yml
+            parameters:
+              ctx: ${{ parameters.ctx }}
+              builder: { os: windows, arch: amd64, distro: '2022' }
+              publishExistingRunID: ${{ parameters.publishExistingRunID }}
 
     # If publishing, always publish the results to a private storage account and
     # publish symbols to AzDO.

eng/pipeline/stages/public-publish-stage.yml

@@ -11,6 +11,9 @@ parameters:
   - name: ctx
     type: object
 
+  - name: pool
+    type: object
+
   - name: id 
     type: string
 
@@ -35,47 +38,61 @@ stages:
 
     jobs:
       - job: ${{ parameters.id }}
-        pool:
-          name: DotNet-Publishing-1ES-MI
+        pool: ${{ parameters.pool }}
         workspace:
           clean: all
         timeoutInMinutes: 240 # 4hr
         ${{ if parameters.templateContext }}:
           templateContext: ${{ parameters.templateContext }}
         variables:
           # Group includes these relevant variables:
-          # - MI_ClientId
           # - ReleaseStudioPublishOwnerAliases
           - group: go-release-config
 
-          - name: GoBinariesDir
-            value: $(Pipeline.Workspace)/Binaries Signed
-          - name: NetCorePublishingScripts
-            value: $(Build.SourcesDirectory)/eng/release-studio/bin/MsGoPublishingScripts
-
           # This is read directly by release studio scripts through env.
           - name: RMExecutionEnvironment
             value: Production
 
+          - name: GoBinariesDir
+            value: $(Pipeline.Workspace)/Binaries Signed
+
+          - name: NetCorePublishingScriptsPackages
+            value: $(Build.SourcesDirectory)/eng/artifacts/MsGoPublishingScripts/Packages
+
           - ${{ each variable in parameters.variables }}:
             - ${{ variable }}
         steps:
           - template: ../steps/checkout-windows-task.yml
           - template: ../steps/find-PublishBranchAlias-task.yml
 
-          - task: NuGetAuthenticate@1
-            displayName: 'Authenticate to AzDO Feeds'
-
-          - task: DotNetCoreCLI@2
-            displayName: 'Acquire tools using csproj'
+          # Install the latest version of the publish tools package. The
+          # floating dependency is recommended by the RM team to allow them to
+          # make updates to the system. UI to fetch the package as a dev is at:
+          # https://dev.azure.com/dnceng/internal/_artifacts/feed/MicroBuildToolset/NuGet/DevDiv.RM.MS.Go.Publishing
+          - task: NuGetCommand@2
+            displayName: NuGet install RM Tools Package
             inputs:
               command: custom
-              projects: '$(Build.SourcesDirectory)/eng/release-studio/ReleaseStudio.csproj'
-              custom: build
+              feedRestore: MicroBuildToolset
               arguments: >-
-                /p:NetCorePublishingScripts=$(NetCorePublishingScripts)
-                /bl:eng/release-studio/Build.binlog
-                /v:n
+                install DevDiv.RM.MS.Go.Publishing
+                -Source https://pkgs.dev.azure.com/dnceng/_packaging/MicroBuildToolset/nuget/v3/index.json
+                -OutputDirectory $(NetCorePublishingScriptsPackages)
+                -Verbosity Detailed
+
+          - pwsh: |
+              $packageDir = Get-ChildItem `
+                -Path $(NetCorePublishingScriptsPackages) `
+                -Filter "DevDiv.RM.MS.Go.Publishing*" `
+                -Directory
+
+              Write-Host "Tools package dir: $packageDir"
+              if ($packageDir.Count -ne 1) {
+                throw "Expected exactly one publishing tools package installed, found $($packageDir.Count)."
+              }
+
+              Write-Output "##vso[task.setvariable variable=NetCorePublishingScripts]$packageDir\scripts"
+            displayName: Find RM Tools scripts directory
 
           - ${{ each step in parameters.steps }}:
             - ${{ step }}

eng/pipeline/stages/public-publish-stages.yml

@@ -9,14 +9,22 @@ parameters:
   - name: ctx
     type: object
 
+  - name: pool
+    type: object
+
   - name: publishExistingRunID
     type: string
     default: 'nil'
 
+  # Unused. Declared so pool selection doesn't fail when trying to pass them.
+  - name: builder
+    type: object
+
 stages:
   - template: public-publish-stage.yml
     parameters:
       ctx: ${{ parameters.ctx }}
+      pool: ${{ parameters.pool }}
 
       id: PublishPublicBinaries
 
@@ -30,13 +38,14 @@ stages:
           parameters:
             runID: ${{ parameters.publishExistingRunID }}
 
-        - task: PowerShell@2
+        - task: AzurePowerShell@5
           displayName: ➡️ Send Publishing Request To Release Studio
           inputs:
-            targetType: filePath
-            filePath: '$(NetCorePublishingScripts)/RM.MsGo.SendPublishRequest.ps1'
-            arguments:
-              -MIClientId "$(MI_ClientId)"
+            ScriptType: FilePath
+            ScriptPath: '$(NetCorePublishingScripts)/RM.MsGo.SendPublishRequest.ps1'
+            azureSubscription: 'golang-dnceng-rs-publish'
+            azurePowerShellVersion: 'LatestVersion'
+            ScriptArguments:
               -PublishingFilesPath "$(GoBinariesDir)"
               -BuildNumber "$(Build.BuildNumber)"
               -BranchName "$(PublishBranchAlias)"
@@ -51,6 +60,7 @@ stages:
   - template: public-publish-stage.yml
     parameters:
       ctx: ${{ parameters.ctx }}
+      pool: ${{ parameters.pool }}
       id: WaitPublicBinaries
       dependsOn: PublishPublicBinaries
       variables:
@@ -64,31 +74,34 @@ stages:
             path: $(ReleaseStudioBinariesManifestDir)
             artifact: Release Studio Binaries Manifest
       steps:
-        - task: PowerShell@2
+        - task: AzurePowerShell@5
           displayName: ⌚ Wait for Publishing Request Completion
           inputs:
-            targetType: filePath
-            filePath: '$(NetCorePublishingScripts)/RM.MsGo.WaitForPublishingRequestToBeLive.ps1'
-            arguments:
-              -MIClientId "$(MI_ClientId)"
+            ScriptType: FilePath
+            ScriptPath: '$(NetCorePublishingScripts)/RM.MsGo.WaitForPublishingRequestToBeLive.ps1'
+            azureSubscription: 'golang-dnceng-rs-publish'
+            azurePowerShellVersion: 'LatestVersion'
+            ScriptArguments:
               -RequestId "$(RequestID)"
 
         - pwsh: New-Item "$(ReleaseStudioBinariesManifestDir)" -ItemType Directory -ErrorAction Ignore
           displayName: 'Create Publish Manifest File Output Directory'
 
-        - task: PowerShell@2
+        - task: AzurePowerShell@5
           displayName: 🗃️ Create Publish Manifest File
           inputs:
-            targetType: filePath
-            filePath: '$(NetCorePublishingScripts)/RM.MsGo.CreateOutputManifestFile.ps1'
-            arguments:
-              -MIClientId "$(MI_ClientId)"
+            ScriptType: FilePath
+            ScriptPath: '$(NetCorePublishingScripts)/RM.MsGo.CreateOutputManifestFile.ps1'
+            azureSubscription: 'golang-dnceng-rs-publish'
+            azurePowerShellVersion: 'LatestVersion'
+            ScriptArguments:
               -OutputDirectory "$(ReleaseStudioBinariesManifestDir)"
               -RequestId "$(RequestID)"
 
   - template: public-publish-stage.yml
     parameters:
       ctx: ${{ parameters.ctx }}
+      pool: ${{ parameters.pool }}
       id: PublishAssetManifest
       dependsOn: WaitPublicBinaries
       variables:
@@ -121,13 +134,14 @@ stages:
               -o '$(BuildAssetsPrePublishDir)/assets.json'
           displayName: 🏗️ Create build asset JSON
 
-        - task: PowerShell@2
+        - task: AzurePowerShell@5
           displayName: ➡️ Send Publishing Request To Release Studio
           inputs:
-            targetType: filePath
-            filePath: '$(NetCorePublishingScripts)/RM.MsGo.SendPublishRequest.ps1'
-            arguments:
-              -MIClientId "$(MI_ClientId)"
+            ScriptType: FilePath
+            ScriptPath: '$(NetCorePublishingScripts)/RM.MsGo.SendPublishRequest.ps1'
+            azureSubscription: 'golang-dnceng-rs-publish'
+            azurePowerShellVersion: 'LatestVersion'
+            ScriptArguments:
               -PublishingFilesPath "$(BuildAssetsPrePublishDir)"
               -BuildNumber "$(Build.BuildNumber)"
               -BranchName "$(PublishBranchAlias)"
@@ -142,6 +156,7 @@ stages:
   - template: public-publish-stage.yml
     parameters:
       ctx: ${{ parameters.ctx }}
+      pool: ${{ parameters.pool }}
       id: WaitAssetManifest
       dependsOn: PublishAssetManifest
       variables:
@@ -160,25 +175,27 @@ stages:
             path: $(ReleaseStudioMetaManifestDir)
             artifact: Release Studio Meta Manifest
       steps:
-        - task: PowerShell@2
+        - task: AzurePowerShell@5
           displayName: ⌚ Wait for Publishing Request Completion
           inputs:
-            targetType: filePath
-            filePath: '$(NetCorePublishingScripts)/RM.MsGo.WaitForPublishingRequestToBeLive.ps1'
-            arguments:
-              -MIClientId "$(MI_ClientId)"
+            ScriptType: FilePath
+            ScriptPath: '$(NetCorePublishingScripts)/RM.MsGo.WaitForPublishingRequestToBeLive.ps1'
+            azureSubscription: 'golang-dnceng-rs-publish'
+            azurePowerShellVersion: 'LatestVersion'
+            ScriptArguments:
               -RequestId "$(RequestID)"
 
         - pwsh: New-Item "$(ReleaseStudioMetaManifestDir)" -ItemType Directory -ErrorAction Ignore
           displayName: 'Create Meta Manifest File Output Directory'
 
-        - task: PowerShell@2
+        - task: AzurePowerShell@5
           displayName: 🗃️ Create Meta Manifest File
           inputs:
-            targetType: filePath
-            filePath: '$(NetCorePublishingScripts)/RM.MsGo.CreateOutputManifestFile.ps1'
-            arguments:
-              -MIClientId "$(MI_ClientId)"
+            ScriptType: FilePath
+            ScriptPath: '$(NetCorePublishingScripts)/RM.MsGo.CreateOutputManifestFile.ps1'
+            azureSubscription: 'golang-dnceng-rs-publish'
+            azurePowerShellVersion: 'LatestVersion'
+            ScriptArguments:
               -OutputDirectory "$(ReleaseStudioMetaManifestDir)"
               -RequestId "$(RequestID)"