Skip to content

Conversation

@IsuminI
Copy link
Contributor

@IsuminI IsuminI commented Nov 19, 2024

We have added Korean translations for lesson 19 to lesson 21.
This is my first time creating a Pull requests, so it might not be perfect. Thank you for your understanding.

@github-actions
Copy link
Contributor

👋 Thanks for contributing @IsuminI! We will review the pull request and get back to you soon.

@IsuminI
Copy link
Contributor Author

IsuminI commented Nov 19, 2024

@microsoft-github-policy-service agree

@github-actions
Copy link
Contributor

Check Broken URLs

We have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue.

Check the file paths and associated broken URLs inside them. For more details, check our Contributing Guide.

File Full Path Issues
04-prompt-engineering-fundamentals/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst284
04-prompt-engineering-fundamentals/translations/ko/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst273
04-prompt-engineering-fundamentals/translations/tw/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst278
04-prompt-engineering-fundamentals/translations/ja-jp/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-yoterada298
04-prompt-engineering-fundamentals/translations/cn/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst271
04-prompt-engineering-fundamentals/translations/pt-br/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst277
17-ai-agents/translations/tw/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/agents/?WT.mc_id=academic-105485-koreyst41
16-open-source-models/README.md
#LinkLine Number
1https://opensource.org/osd?WT.mc_id=academic-105485-koreyst15
16-open-source-models/translations/tw/README.md
#LinkLine Number
1https://opensource.org/osd?WT.mc_id=academic-105485-koreyst15

@scorpion20144
Copy link

hi
how are you?
i am from IRAN
I am happy to meet you

@github-actions
Copy link
Contributor

Check Broken URLs

We have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue.

Check the file paths and associated broken URLs inside them. For more details, check our Contributing Guide.

File Full Path Issues
04-prompt-engineering-fundamentals/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst284
04-prompt-engineering-fundamentals/translations/ko/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst273
04-prompt-engineering-fundamentals/translations/tw/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst278
04-prompt-engineering-fundamentals/translations/ja-jp/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-yoterada298
04-prompt-engineering-fundamentals/translations/cn/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst271
04-prompt-engineering-fundamentals/translations/pt-br/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst277
17-ai-agents/translations/tw/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/agents/?WT.mc_id=academic-105485-koreyst41

@IsuminI IsuminI mentioned this pull request Nov 27, 2024
@koreyspace koreyspace merged commit a353e16 into microsoft:main Nov 28, 2024
5 of 6 checks passed
xukai286 pushed a commit to xukai286/generative-ai-for-beginners that referenced this pull request Apr 25, 2025
…nslations-19-21

Add Korean translations (ko) for Lesson 19-21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants