Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Commit 289db1d

Browse files
connieyconniey
authored
Merge pull request #725 from Microsoft/dev
Changes: * Style-cop changes * Ignore resource DLLs * Improve locating System.Object dll * Add DGML report formatter * Update VSIX to use AsyncPackage * Remove Ubuntu14.04 CI build because it is covered by Ubuntu16.04
2 parents 94f0f02 + 19f18f2 commit 289db1d

File tree

184 files changed

+2542
-1271
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

184 files changed

+2542
-1271
lines changed

‎PortabilityTools.sln‎

Lines changed: 53 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
Microsoft Visual Studio Solution File, Format Version 12.00
3-
# Visual Studio 15
4-
VisualStudioVersion = 15.0.27130.2036
3+
# Visual Studio Version 16
4+
VisualStudioVersion = 16.0.28210.120
55
MinimumVisualStudioVersion = 10.0.40219.1
66
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{C991F5FC-04B5-420C-98A0-80974AA946F7}"
77
ProjectSection(SolutionItems) = preProject
@@ -82,6 +82,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "ApiPort", "ApiPort", "{C2CF
8282
EndProject
8383
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "lib", "lib", "{CB5759DE-9D7B-4B21-89BC-E81920D611BB}"
8484
EndProject
85+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Fx.Portability.Reports.DGML", "src\lib\Microsoft.Fx.Portability.Reports.DGML\Microsoft.Fx.Portability.Reports.DGML.csproj", "{1B6E53A7-9180-4D79-9556-E5CE59483EA1}"
86+
EndProject
8587
Global
8688
GlobalSection(SolutionConfigurationPlatforms) = preSolution
8789
Debug|Any CPU = Debug|Any CPU
@@ -1046,6 +1048,54 @@ Global
10461048
{2DFBC0D7-E65F-4F85-9E60-5F6C4BA8F4FE}.Ubuntu_Release|x64.Build.0 = Release|Any CPU
10471049
{2DFBC0D7-E65F-4F85-9E60-5F6C4BA8F4FE}.Ubuntu_Release|x86.ActiveCfg = Release|Any CPU
10481050
{2DFBC0D7-E65F-4F85-9E60-5F6C4BA8F4FE}.Ubuntu_Release|x86.Build.0 = Release|Any CPU
1051+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
1052+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Debug|Any CPU.Build.0 = Debug|Any CPU
1053+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Debug|ARM.ActiveCfg = Debug|Any CPU
1054+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Debug|ARM.Build.0 = Debug|Any CPU
1055+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Debug|x64.ActiveCfg = Debug|Any CPU
1056+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Debug|x64.Build.0 = Debug|Any CPU
1057+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Debug|x86.ActiveCfg = Debug|Any CPU
1058+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Debug|x86.Build.0 = Debug|Any CPU
1059+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Debug|Any CPU.ActiveCfg = Debug|Any CPU
1060+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Debug|Any CPU.Build.0 = Debug|Any CPU
1061+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Debug|ARM.ActiveCfg = Debug|Any CPU
1062+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Debug|ARM.Build.0 = Debug|Any CPU
1063+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Debug|x64.ActiveCfg = Debug|Any CPU
1064+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Debug|x64.Build.0 = Debug|Any CPU
1065+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Debug|x86.ActiveCfg = Debug|Any CPU
1066+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Debug|x86.Build.0 = Debug|Any CPU
1067+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Release|Any CPU.ActiveCfg = Release|Any CPU
1068+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Release|Any CPU.Build.0 = Release|Any CPU
1069+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Release|ARM.ActiveCfg = Release|Any CPU
1070+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Release|ARM.Build.0 = Release|Any CPU
1071+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Release|x64.ActiveCfg = Release|Any CPU
1072+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Release|x64.Build.0 = Release|Any CPU
1073+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Release|x86.ActiveCfg = Release|Any CPU
1074+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Osx_Release|x86.Build.0 = Release|Any CPU
1075+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Release|Any CPU.ActiveCfg = Release|Any CPU
1076+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Release|Any CPU.Build.0 = Release|Any CPU
1077+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Release|ARM.ActiveCfg = Release|Any CPU
1078+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Release|ARM.Build.0 = Release|Any CPU
1079+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Release|x64.ActiveCfg = Release|Any CPU
1080+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Release|x64.Build.0 = Release|Any CPU
1081+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Release|x86.ActiveCfg = Release|Any CPU
1082+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Release|x86.Build.0 = Release|Any CPU
1083+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Debug|Any CPU.ActiveCfg = Debug|Any CPU
1084+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Debug|Any CPU.Build.0 = Debug|Any CPU
1085+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Debug|ARM.ActiveCfg = Debug|Any CPU
1086+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Debug|ARM.Build.0 = Debug|Any CPU
1087+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Debug|x64.ActiveCfg = Debug|Any CPU
1088+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Debug|x64.Build.0 = Debug|Any CPU
1089+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Debug|x86.ActiveCfg = Debug|Any CPU
1090+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Debug|x86.Build.0 = Debug|Any CPU
1091+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Release|Any CPU.ActiveCfg = Release|Any CPU
1092+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Release|Any CPU.Build.0 = Release|Any CPU
1093+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Release|ARM.ActiveCfg = Release|Any CPU
1094+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Release|ARM.Build.0 = Release|Any CPU
1095+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Release|x64.ActiveCfg = Release|Any CPU
1096+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Release|x64.Build.0 = Release|Any CPU
1097+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Release|x86.ActiveCfg = Release|Any CPU
1098+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1}.Ubuntu_Release|x86.Build.0 = Release|Any CPU
10491099
EndGlobalSection
10501100
GlobalSection(SolutionProperties) = preSolution
10511101
HideSolutionNode = FALSE
@@ -1076,6 +1126,7 @@ Global
10761126
{D66AC566-3B80-46F0-8687-3C5F4D203F1A} = {6234AABE-C4F3-4094-9C0D-FFD589235DBE}
10771127
{C2CF3FE7-5A24-4FEF-B833-86FBAC5D5731} = {7DC7AA2C-0401-495B-B42C-32F44085EBE6}
10781128
{CB5759DE-9D7B-4B21-89BC-E81920D611BB} = {7DC7AA2C-0401-495B-B42C-32F44085EBE6}
1129+
{1B6E53A7-9180-4D79-9556-E5CE59483EA1} = {D66AC566-3B80-46F0-8687-3C5F4D203F1A}
10791130
EndGlobalSection
10801131
GlobalSection(ExtensibilityGlobals) = postSolution
10811132
SolutionGuid = {8E8B2DB2-4847-4909-8631-A995D50F10EF}

‎docs/RecommendedChanges/System/Remove usage.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ Remove usage.
33

44
### Affected APIs
55
* `T:System.AccessViolationException`
6-
* `T:System.AppDomain`
76
* `T:System.AppDomainManager`
87
* `T:System.AppDomainManagerInitializationOptions`
98
* `T:System.AppDomainSetup`

‎docs/RecommendedChanges/System/Use AssemblyBuilder.DefineDynamicAssembly.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
### Recommended Action
2+
Use AssemblyBuilder.DefineDynamicAssembly
3+
4+
### Affected APIs
5+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess)`
6+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess,System.Security.Policy.Evidence)`
7+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess,System.Security.Policy.Evidence,System.Security.PermissionSet,System.Security.PermissionSet,System.Security.PermissionSet)`
8+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess,System.Collections.Generic.IEnumerable{System.Reflection.Emit.CustomAttributeBuilder})`
9+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess,System.Collections.Generic.IEnumerable{System.Reflection.Emit.CustomAttributeBuilder},System.Security.SecurityContextSource)`
10+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess,System.Security.PermissionSet,System.Security.PermissionSet,System.Security.PermissionSet)`
11+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess,System.String)`
12+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess,System.String,System.Boolean,System.Collections.Generic.IEnumerable{System.Reflection.Emit.CustomAttributeBuilder})`
13+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess,System.String,System.Security.Policy.Evidence)`
14+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess,System.String,System.Security.Policy.Evidence,System.Security.PermissionSet,System.Security.PermissionSet,System.Security.PermissionSet)`
15+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess,System.String,System.Security.Policy.Evidence,System.Security.PermissionSet,System.Security.PermissionSet,System.Security.PermissionSet,System.Boolean)`
16+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess,System.String,System.Security.Policy.Evidence,System.Security.PermissionSet,System.Security.PermissionSet,System.Security.PermissionSet,System.Boolean,System.Collections.Generic.IEnumerable{System.Reflection.Emit.CustomAttributeBuilder})`
17+
* `M:System.AppDomain.DefineDynamicAssembly(System.Reflection.AssemblyName,System.Reflection.Emit.AssemblyBuilderAccess,System.String,System.Security.PermissionSet,System.Security.PermissionSet,System.Security.PermissionSet)`

‎netci.groovy‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import jobs.generation.Utilities;
44
def project = GithubProject
55
def branch = GithubBranchName
66
def configurationGroups = ['Debug', 'Release']
7-
def outerloopPlatforms = ['Windows_NT', 'Ubuntu14.04', 'Ubuntu16.04', 'OSX10.12']
7+
def outerloopPlatforms = ['Windows_NT', 'Ubuntu16.04', 'OSX10.12']
88

99
// Generate the builds for debug and release, commit and PRJob
1010
[true, false].each { isPR -> // Defines a closure over true and false, value assigned to isPR

‎rules.ruleset‎

Lines changed: 0 additions & 163 deletions
Original file line numberDiff line numberDiff line change
@@ -47,186 +47,23 @@
4747
</Rules>
4848
<Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
4949
<Rule Id="SA0001" Action="None" />
50-
<Rule Id="SA1000" Action="None" />
51-
<Rule Id="SA1001" Action="None" />
52-
<Rule Id="SA1002" Action="None" />
53-
<Rule Id="SA1003" Action="None" />
54-
<Rule Id="SA1004" Action="None" />
55-
<Rule Id="SA1005" Action="None" />
56-
<Rule Id="SA1006" Action="None" />
57-
<Rule Id="SA1007" Action="None" />
58-
<Rule Id="SA1008" Action="None" />
59-
<Rule Id="SA1009" Action="None" />
60-
<Rule Id="SA1010" Action="None" />
61-
<Rule Id="SA1011" Action="None" />
62-
<Rule Id="SA1012" Action="None" />
63-
<Rule Id="SA1013" Action="None" />
64-
<Rule Id="SA1014" Action="None" />
65-
<Rule Id="SA1015" Action="None" />
66-
<Rule Id="SA1016" Action="None" />
67-
<Rule Id="SA1017" Action="None" />
68-
<Rule Id="SA1018" Action="None" />
69-
<Rule Id="SA1019" Action="None" />
70-
<Rule Id="SA1020" Action="None" />
71-
<Rule Id="SA1021" Action="None" />
72-
<Rule Id="SA1022" Action="None" />
73-
<Rule Id="SA1023" Action="None" />
74-
<Rule Id="SA1024" Action="None" />
75-
<Rule Id="SA1025" Action="None" />
76-
<Rule Id="SA1026" Action="None" />
77-
<Rule Id="SA1027" Action="None" />
78-
<Rule Id="SA1028" Action="None" />
79-
<Rule Id="SA1100" Action="None" />
8050
<Rule Id="SA1101" Action="None" />
81-
<Rule Id="SA1102" Action="None" />
82-
<Rule Id="SA1103" Action="None" />
83-
<Rule Id="SA1104" Action="None" />
84-
<Rule Id="SA1105" Action="None" />
85-
<Rule Id="SA1106" Action="None" />
86-
<Rule Id="SA1107" Action="None" />
87-
<Rule Id="SA1108" Action="None" />
88-
<Rule Id="SA1109" Action="None" />
89-
<Rule Id="SA1110" Action="None" />
90-
<Rule Id="SA1111" Action="None" />
91-
<Rule Id="SA1112" Action="None" />
92-
<Rule Id="SA1113" Action="None" />
93-
<Rule Id="SA1114" Action="None" />
94-
<Rule Id="SA1115" Action="None" />
9551
<Rule Id="SA1116" Action="None" />
9652
<Rule Id="SA1117" Action="None" />
97-
<Rule Id="SA1118" Action="None" />
98-
<Rule Id="SA1119" Action="None" />
99-
<Rule Id="SA1120" Action="None" />
100-
<Rule Id="SA1121" Action="None" />
101-
<Rule Id="SA1122" Action="None" />
102-
<Rule Id="SA1123" Action="None" />
10353
<Rule Id="SA1124" Action="None" />
104-
<Rule Id="SA1125" Action="None" />
105-
<Rule Id="SA1126" Action="None" />
106-
<Rule Id="SA1127" Action="None" />
107-
<Rule Id="SA1128" Action="None" />
108-
<Rule Id="SA1129" Action="None" />
109-
<Rule Id="SA1130" Action="None" />
110-
<Rule Id="SA1131" Action="None" />
111-
<Rule Id="SA1132" Action="None" />
112-
<Rule Id="SA1133" Action="None" />
113-
<Rule Id="SA1134" Action="None" />
114-
<Rule Id="SA1135" Action="None" />
115-
<Rule Id="SA1136" Action="None" />
116-
<Rule Id="SA1137" Action="None" />
117-
<Rule Id="SA1138" Action="None" />
118-
<Rule Id="SA1139" Action="None" />
11954
<Rule Id="SA1200" Action="None" />
12055
<Rule Id="SA1201" Action="None" />
12156
<Rule Id="SA1202" Action="None" />
122-
<Rule Id="SA1203" Action="None" />
12357
<Rule Id="SA1204" Action="None" />
124-
<Rule Id="SA1205" Action="None" />
125-
<Rule Id="SA1206" Action="None" />
126-
<Rule Id="SA1207" Action="None" />
127-
<Rule Id="SA1208" Action="None" />
128-
<Rule Id="SA1209" Action="None" />
129-
<Rule Id="SA1210" Action="None" />
130-
<Rule Id="SA1211" Action="None" />
131-
<Rule Id="SA1212" Action="None" />
132-
<Rule Id="SA1213" Action="None" />
133-
<Rule Id="SA1214" Action="None" />
134-
<Rule Id="SA1215" Action="None" />
135-
<Rule Id="SA1216" Action="None" />
136-
<Rule Id="SA1217" Action="None" />
137-
<Rule Id="SA1300" Action="None" />
138-
<Rule Id="SA1301" Action="None" />
139-
<Rule Id="SA1302" Action="None" />
140-
<Rule Id="SA1303" Action="None" />
141-
<Rule Id="SA1304" Action="None" />
142-
<Rule Id="SA1306" Action="None" />
143-
<Rule Id="SA1307" Action="None" />
144-
<Rule Id="SA1308" Action="None" />
14558
<Rule Id="SA1309" Action="None" />
14659
<Rule Id="SA1310" Action="None" />
147-
<Rule Id="SA1311" Action="None" />
148-
<Rule Id="SA1312" Action="None" />
149-
<Rule Id="SA1313" Action="None" />
150-
<Rule Id="SA1314" Action="None" />
151-
<Rule Id="SA1400" Action="None" />
152-
<Rule Id="SA1401" Action="None" />
15360
<Rule Id="SA1402" Action="None" />
154-
<Rule Id="SA1403" Action="None" />
155-
<Rule Id="SA1404" Action="None" />
156-
<Rule Id="SA1405" Action="None" />
157-
<Rule Id="SA1406" Action="None" />
158-
<Rule Id="SA1407" Action="None" />
159-
<Rule Id="SA1408" Action="None" />
160-
<Rule Id="SA1409" Action="None" />
161-
<Rule Id="SA1410" Action="None" />
162-
<Rule Id="SA1411" Action="None" />
16361
<Rule Id="SA1412" Action="Warning" />
16462
<Rule Id="SA1413" Action="None" />
165-
<Rule Id="SA1500" Action="None" />
166-
<Rule Id="SA1501" Action="None" />
16763
<Rule Id="SA1502" Action="None" />
16864
<Rule Id="SA1503" Action="None" />
169-
<Rule Id="SA1504" Action="None" />
170-
<Rule Id="SA1505" Action="None" />
171-
<Rule Id="SA1506" Action="None" />
172-
<Rule Id="SA1508" Action="None" />
173-
<Rule Id="SA1509" Action="None" />
174-
<Rule Id="SA1510" Action="None" />
175-
<Rule Id="SA1511" Action="None" />
176-
<Rule Id="SA1512" Action="None" />
177-
<Rule Id="SA1513" Action="None" />
178-
<Rule Id="SA1514" Action="None" />
179-
<Rule Id="SA1515" Action="None" />
180-
<Rule Id="SA1516" Action="None" />
181-
<Rule Id="SA1517" Action="None" />
182-
<Rule Id="SA1519" Action="None" />
183-
<Rule Id="SA1520" Action="None" />
18465
<Rule Id="SA1600" Action="None" />
185-
<Rule Id="SA1601" Action="None" />
186-
<Rule Id="SA1602" Action="None" />
187-
<Rule Id="SA1603" Action="None" />
188-
<Rule Id="SA1604" Action="None" />
189-
<Rule Id="SA1605" Action="None" />
190-
<Rule Id="SA1606" Action="None" />
191-
<Rule Id="SA1607" Action="None" />
192-
<Rule Id="SA1608" Action="None" />
193-
<Rule Id="SA1610" Action="None" />
19466
<Rule Id="SA1611" Action="None" />
195-
<Rule Id="SA1612" Action="None" />
196-
<Rule Id="SA1613" Action="None" />
197-
<Rule Id="SA1614" Action="None" />
19867
<Rule Id="SA1615" Action="None" />
199-
<Rule Id="SA1616" Action="None" />
200-
<Rule Id="SA1617" Action="None" />
201-
<Rule Id="SA1618" Action="None" />
202-
<Rule Id="SA1619" Action="None" />
203-
<Rule Id="SA1620" Action="None" />
204-
<Rule Id="SA1621" Action="None" />
205-
<Rule Id="SA1622" Action="None" />
206-
<Rule Id="SA1623" Action="None" />
207-
<Rule Id="SA1624" Action="None" />
208-
<Rule Id="SA1625" Action="None" />
209-
<Rule Id="SA1626" Action="None" />
210-
<Rule Id="SA1627" Action="None" />
211-
<Rule Id="SA1628" Action="None" />
212-
<Rule Id="SA1629" Action="None" />
213-
<Rule Id="SA1630" Action="None" />
214-
<Rule Id="SA1631" Action="None" />
215-
<Rule Id="SA1632" Action="None" />
216-
<Rule Id="SA1637" Action="None" />
217-
<Rule Id="SA1638" Action="None" />
218-
<Rule Id="SA1640" Action="None" />
219-
<Rule Id="SA1641" Action="None" />
220-
<Rule Id="SA1642" Action="None" />
221-
<Rule Id="SA1643" Action="None" />
222-
<Rule Id="SA1644" Action="None" />
223-
<Rule Id="SA1645" Action="None" />
224-
<Rule Id="SA1646" Action="None" />
225-
<Rule Id="SA1647" Action="None" />
226-
<Rule Id="SA1648" Action="None" />
227-
<Rule Id="SA1649" Action="None" />
228-
<Rule Id="SA1650" Action="None" />
229-
<Rule Id="SA1651" Action="None" />
230-
<Rule Id="SA1652" Action="None" />
23168
</Rules>
23269
</RuleSet>

‎src/ApiPort/ApiPort.VisualStudio.2017/ProjectBuilder2017.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
using System.Linq;
1616
using System.Threading;
1717
using System.Threading.Tasks;
18+
1819
using static Microsoft.Fx.Portability.Utils.FormattableStringHelper;
1920

2021
namespace ApiPortVS.VS2017

‎src/ApiPort/ApiPort.VisualStudio.2017/ServiceProvider.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ public class ServiceProvider : Module
1313
{
1414
protected override void Load(ContainerBuilder builder)
1515
{
16-
builder.RegisterAdapter<IServiceProvider, IProjectService>(serviceProvider => {
16+
builder.RegisterAdapter<IServiceProvider, IProjectService>(serviceProvider =>
17+
{
1718
var componentModel = serviceProvider.GetService(typeof(SComponentModel)) as IComponentModel;
1819
var projectServiceAccessor = componentModel.GetService<IProjectServiceAccessor>();
1920
return projectServiceAccessor.GetProjectService();

‎src/ApiPort/ApiPort.VisualStudio.Common/AssemblyFile.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
// Copyright (c) Microsoft. All rights reserved.
22
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
33

4+
using Microsoft.Fx.Portability;
45
using System;
56
using System.Collections.Generic;
67
using System.Diagnostics;
78
using System.IO;
8-
using Microsoft.Fx.Portability;
99

1010
namespace ApiPortVS
1111
{

‎src/ApiPort/ApiPort.VisualStudio.Common/ComProjectMapper.cs‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@
88
using System;
99
using System.Diagnostics;
1010
using System.Threading.Tasks;
11-
using VisualStudio = Microsoft.VisualStudio.Shell;
11+
1212
using static Microsoft.Fx.Portability.Utils.FormattableStringHelper;
1313

14+
using VisualStudio = Microsoft.VisualStudio.Shell;
15+
1416
namespace ApiPortVS
1517
{
1618
/// <summary>
@@ -77,6 +79,7 @@ public async Task<IVsCfg> GetVsProjectConfigurationAsync(Project project)
7779
Trace.TraceError(ToCurrentCulture($"Could not retrieve {nameof(IVsCfgProvider)} from project: {project.Name}"));
7880
return null;
7981
}
82+
8083
if (!(provider is IVsCfgProvider2))
8184
{
8285
Trace.TraceError(ToCurrentCulture($"IVsCfgProvider returned {provider.GetType()} is not of the right type. Expected: {nameof(IVsCfgProvider2)}"));

‎src/ApiPort/ApiPort.VisualStudio.Common/Contracts/IErrorListProvider.cs‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ public interface IErrorListProvider
1515
/// <summary>
1616
/// Displays given source mapped items in the error window.
1717
/// </summary>
18-
/// <param name="items"></param>
19-
/// <param name="projects"></param>
20-
/// <returns></returns>
2118
Task DisplaySourceItemsAsync(IEnumerable<ISourceMappedItem> items, ICollection<CalculatedProject> projects);
2219
}
2320
}

0 commit comments

Comments
 (0)