Skip to content

feat: Replace Quick Accent toolbar position dropdown with visual 3x3 grid #44113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThanhNguyxn wants to merge 4 commits into
base: main
Choose a base branch
from
+224 −12
Open

feat: Replace Quick Accent toolbar position dropdown with visual 3x3 grid #44113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93cd0f6
feat: Replace Quick Accent toolbar position dropdown with 3x3 visual …
ThanhNguyxn Dec 6, 2025
caf8b3f
refactor: Address Copilot review suggestions
ThanhNguyxn Dec 6, 2025
200ec88
fix: Address PR review - add localization, tooltips, accessibility
ThanhNguyxn Dec 6, 2025
d769ff4
Fix: Build error and potential crash in Quick Accent toolbar position…
ThanhNguyxn Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions src/settings-ui/Settings.UI/Strings/en-us/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3507,6 +3507,61 @@ Activate by holding the key for the character you want to add an accent to, then
<data name="QuickAccent_ToolbarPosition_Right.Content" xml:space="preserve">
<value>Right</value>
</data>
<!-- Toolbar position ToolTip and Accessibility strings -->
Copy link
Collaborator

@jiripolasek jiripolasek Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put extra changes to a generated file. It would require an effort to maintain this for anyone making changes to the file.

<data name="QuickAccent_ToolbarPosition_TopCenter.ToolTip" xml:space="preserve">
<value>Top center</value>
</data>
<data name="QuickAccent_ToolbarPosition_TopCenter.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Top center</value>
</data>
<data name="QuickAccent_ToolbarPosition_TopLeftCorner.ToolTip" xml:space="preserve">
<value>Top left corner</value>
</data>
<data name="QuickAccent_ToolbarPosition_TopLeftCorner.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Top left corner</value>
</data>
<data name="QuickAccent_ToolbarPosition_TopRightCorner.ToolTip" xml:space="preserve">
<value>Top right corner</value>
</data>
<data name="QuickAccent_ToolbarPosition_TopRightCorner.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Top right corner</value>
</data>
<data name="QuickAccent_ToolbarPosition_BottomLeftCorner.ToolTip" xml:space="preserve">
<value>Bottom left corner</value>
</data>
<data name="QuickAccent_ToolbarPosition_BottomLeftCorner.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Bottom left corner</value>
</data>
<data name="QuickAccent_ToolbarPosition_BottomCenter.ToolTip" xml:space="preserve">
<value>Bottom center</value>
</data>
<data name="QuickAccent_ToolbarPosition_BottomCenter.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Bottom center</value>
</data>
<data name="QuickAccent_ToolbarPosition_BottomRightCorner.ToolTip" xml:space="preserve">
<value>Bottom right corner</value>
</data>
<data name="QuickAccent_ToolbarPosition_BottomRightCorner.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Bottom right corner</value>
</data>
<data name="QuickAccent_ToolbarPosition_Center.ToolTip" xml:space="preserve">
<value>Center</value>
</data>
<data name="QuickAccent_ToolbarPosition_Center.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Center</value>
</data>
<data name="QuickAccent_ToolbarPosition_Left.ToolTip" xml:space="preserve">
<value>Left</value>
</data>
<data name="QuickAccent_ToolbarPosition_Left.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Left</value>
</data>
<data name="QuickAccent_ToolbarPosition_Right.ToolTip" xml:space="preserve">
<value>Right</value>
</data>
<data name="QuickAccent_ToolbarPosition_Right.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Right</value>
</data>
<data name="QuickAccent_Behavior.Header" xml:space="preserve">
<value>Behavior</value>
</data>
Expand Down
6 changes: 6 additions & 0 deletions src/settings-ui/Settings.UI/ViewModels/PowerAccentViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,12 @@ public int ToolbarPositionIndex

set
{
// Validate index is within bounds to prevent crash
if (value < 0 || value >= _toolbarOptions.Length)
{
return;
}

if (_toolbarPositionIndex != value)
{
_toolbarPositionIndex = value;
Expand Down