Execution Tests: Update Long Vector tests to no longer require ShaderOpArith.xml #7999
+958
−904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsepkow
force-pushed
the
user/alsepkow/EmbedShaderOpArith
branch
from
856a052 to
5dcffe9
Compare
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
alsepkow
force-pushed
the
user/alsepkow/EmbedShaderOpArith
branch
from
5dcffe9 to
0fc5d9e
Compare
alsepkow
commented
Dec 11, 2025
| IStream **TestXML, dxc::SpecificDllLoader &Support) { | ||
|
|
||
| DllWrapper Dll; | ||
| Dll.Module = LoadLibraryEx(TEXT("ExecHLSLTests.dll"), nullptr, |
Contributor
Author
There was a problem hiding this comment.
@damyanp You mentioned the hard coded module name would be a problem here. I think we can change to using the name from GetModuleFileName to handle the tests have a different dll name?
Member
There was a problem hiding this comment.
What HMODULE would you pass to GetModuleFilename?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR embeds the xml file used by the Long Vector tests into ExecHlslTests.dll. Removing the need to provide /p:HlslDataDir at runtime. Also moved the relevant data out of ShaderOpArith.xml into its own LongVectorOp.xml file.