Rewrite GitHub Pages Publish to use official action (#708)

* Rewrite GitHub Pages Publish to use official action

* Update pipeline templates to latest

* Fix Indent

* Update image names to match new template values

Author: gfs

.github/workflows/publish-docs.yml

@@ -1,38 +1,34 @@
 name: Publish GH - Pages
+# Based on https://github.com/actions/starter-workflows/blob/main/pages/static.yml
 
+# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
 permissions:
   contents: read
   pages: write
+  id-token: write
+
+# Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued.
+# However, do NOT cancel in-progress runs as we want to allow these production deployments to complete.
+concurrency:
+  group: "pages"
+  cancel-in-progress: false
 
 on:
   push:
-    branches: [ main, release/v2.2, release/v2.3 ]
-
+    branches: [ release/v2.3 ]
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:
 jobs:
-  build:
-
+  deploy:
+    environment:
+      name: github-pages
+      url: ${{ steps.deployment.outputs.page_url }}
     runs-on: windows-latest
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
       with:
         fetch-depth: 0
-    - name: Set Docs Locations
-      id: branch
-      run: |
-        $branchName = "${{ github.ref }}"
-        # refs/heads/ is 11 characters
-        $branchName = $branchName.Substring(11)
-
-        if($branchName.StartsWith("release/")) 
-        { 
-          $branchName = $branchName.Substring(8)
-        }
-        elseif ($branchName -eq "main")
-        {
-          $branchName = ""
-        }
-        echo "::set-output name=DOCS_LOCATION::$branchName" 
     - name: Setup .NET Core
       uses: actions/setup-dotnet@v1
       with:
@@ -43,11 +39,13 @@ jobs:
       run: choco install docfx
     - name: Run DocFx
       run: docfx docfx/docfx.json
-    - name: Upload to GitHub Pages
-      uses: peaceiris/[email protected]
+    - name: Setup Pages
+      uses: actions/configure-pages@v4
+    - name: Upload artifact
+      uses: actions/upload-pages-artifact@v3
       with:
-        github_token: ${{ secrets.GITHUB_TOKEN }}
-        publish_dir: docfx/_site
-        destination_dir: ${{ steps.branch.outputs.DOCS_LOCATION }}
-        keep_files: true
-        full_commit_message: Deploy ${{ steps.branch.outputs.DOCS_LOCATION }} to GitHub Pages
+        # Upload build docfx site
+        path: 'docfx/_site'
+    - name: Deploy to GitHub Pages
+      id: deployment
+      uses: actions/deploy-pages@v4

Pipelines/asa-pr.yml

@@ -22,7 +22,7 @@ resources:
     - repository: templates
       type: git
       name: SecurityEngineering/OSS-Tools-Pipeline-Templates
-      ref: refs/tags/v1.1.0
+      ref: refs/tags/v1.1.1
 
 variables:
   BuildConfiguration: 'Release'
@@ -37,7 +37,7 @@ stages:
     parameters:
       jobName: 'dotnet_test_windows'
       dotnetVersions: ['6.0.x','7.0.x','8.0.x']
-      vmImage: 'oss-tools-win2022_1es-managed'
+      vmImage: 'win2022-image-base'
       projectPath: 'Tests/Tests.csproj'
 
 - stage: SDL

Pipelines/asa-release.yml

@@ -20,7 +20,7 @@ resources:
     - repository: templates
       type: git
       name: SecurityEngineering/OSS-Tools-Pipeline-Templates
-      ref: refs/tags/v1.1.0
+      ref: refs/tags/v1.1.1
 
 variables:
   BuildConfiguration: 'Release'
@@ -35,7 +35,7 @@ stages:
     parameters:
       jobName: 'dotnet_test_windows'
       dotnetVersions: ['6.0.x','7.0.x','8.0.x']
-      vmImage: 'oss-tools-win2022_1es-managed'
+      vmImage: 'win2022-image-base'
       projectPath: 'Tests/Tests.csproj'
 
 - stage: SDL
@@ -95,7 +95,7 @@ stages:
     displayName: Code Sign, Generate Hashes, Publish Public Releases
     pool:
       name: 'OSS-Tools-1ESPool'
-      vmImage: 'oss-tools-win2022_1es-managed'
+      vmImage: 'win2022-image-base'
     steps:
     - task: UseDotNet@2 # For ESRP. Do not use variable.
       inputs: