add new setting controlling PII filtering for CNIL #23869
Merged
+204
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caddoo
approved these changes
Dec 7, 2025
Contributor
There was a problem hiding this comment.
I've tested this locally by:
- Disabling CNIL mode.
- Tracking a visit with PII as query param
- Observe it in the visitors log.
- Enable CNIL mode.
- Tracking a visit with PII as query param.
- Disable CNIL mode (so I can see the visitor log).
- Observe the PII isn't in there.
There will probably be product feedback around how this is implemented but this is a step in the right direction.
| /** | ||
| * @dataProvider getExclusionTypesWithPolicyStatuses | ||
| */ | ||
| public function testGetExclusionTypeForQueryParamsReturnsCorrectTypeWithCnilPolicy(bool $featureFlagEnabled, string $policy, bool $policyEnabled, string $exclusionTypeToSet, string $expectedExclusionType) |
Contributor
There was a problem hiding this comment.
Suggested change
| public function testGetExclusionTypeForQueryParamsReturnsCorrectTypeWithCnilPolicy(bool $featureFlagEnabled, string $policy, bool $policyEnabled, string $exclusionTypeToSet, string $expectedExclusionType) | |
| public function testGetExclusionTypeForQueryParamsReturnsCorrectTypeWithCnilPolicy(bool $featureFlagEnabled, string $policy, bool $policyEnabled, string $exclusionTypeToSet, string $expectedExclusionType): void |
| $config->FeatureFlags = [$featureFlagConfig => 'disabled']; | ||
| } | ||
|
|
||
| public function getExclusionTypesWithPolicyStatuses() |
Contributor
There was a problem hiding this comment.
Suggested change
| public function getExclusionTypesWithPolicyStatuses() | |
| public function getExclusionTypesWithPolicyStatuses(): \Generator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new policy setting to the CNIL dashboard that ensures PII is correctly filtered from incoming tracking requests. Currently an instance/site is considered compliant if the existing global website setting is set to 'Matomo recommended PII'. The ability to replicate this setting value of 'Matomo recommended PII' with the 'custom' option has been deemed out of scope.
Checklist
Review