Skip to content

Conversation

@chippison
Copy link
Contributor

@chippison chippison commented Dec 2, 2025

Description

DEV-19732

We sometimes need to have the sourcemaps of our built vue files to be included for easier debugging.
This might not be useful all the time, but there would be cases that it might be easier.

We have added an optional parameter we can include when running our ddev matomo:init:dev command so that we can include the sourcemaps. This is also reversible, meaning we could exclude loading of sourcemaps at anytime as well.

NOTE: Remember to disable browser cache when enabling/disabling sourcemaps so that changes reflect immediately

Checklist

  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules

Review

@chippison chippison marked this pull request as ready for review December 2, 2025 03:28
@chippison chippison requested a review from a team December 2, 2025 03:28
Comment on lines +10 to +14
WITH_MAPS=1
fi
done

MAP_FLAG_VALUE=$([ "$WITH_MAPS" -eq 1 ] && echo 1 || echo 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between WITH_MAPS and MAP_FLAG_VALUE?


To see help:
```
ddev help matomo:init:dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Add Development.allow_vue_sourcemaps in the config file documentation

Copy link
Contributor

@tzi tzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No critical feedback, so let’s go!
Thanks for this 🚀

@caddoo
Copy link
Contributor

caddoo commented Dec 7, 2025

Also tested this locally to make sure it worked for me in brave/chrome.

image

We should consider this default on, let's see how it works for us now and then we can change it later.

@caddoo caddoo merged commit ac0a05e into 5.x-dev Dec 7, 2025
27 of 29 checks passed
@caddoo caddoo deleted the add-source-maps branch December 7, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants