-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add the option to include source maps to served files #23857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| WITH_MAPS=1 | ||
| fi | ||
| done | ||
|
|
||
| MAP_FLAG_VALUE=$([ "$WITH_MAPS" -eq 1 ] && echo 1 || echo 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between WITH_MAPS and MAP_FLAG_VALUE?
|
|
||
| To see help: | ||
| ``` | ||
| ddev help matomo:init:dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ Add Development.allow_vue_sourcemaps in the config file documentation
tzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No critical feedback, so let’s go!
Thanks for this 🚀

Description
DEV-19732
We sometimes need to have the sourcemaps of our built vue files to be included for easier debugging.
This might not be useful all the time, but there would be cases that it might be easier.
We have added an optional parameter we can include when running our
ddev matomo:init:devcommand so that we can include the sourcemaps. This is also reversible, meaning we could exclude loading of sourcemaps at anytime as well.NOTE: Remember to disable browser cache when enabling/disabling sourcemaps so that changes reflect immediately
Checklist
Review