[release 1.14] downgrade AAQ to v1.3.0 #3910
Conversation
We can't compile with AAQ 1.3.1 in openshift CI, as go1.22 there is 1.22.9, while AAQ requires 1.22.11 Signed-off-by: Nahshon Unna Tsameret <[email protected]>
kubevirt-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
nunnatsa
changed the title
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- In go.mod you downgraded the
godirective to 1.22.9 but addedtoolchain go1.22.11, which seems to reintroduce the same version constraint you are trying to avoid; consider removing or aligning the toolchain directive with what is actually available in OpenShift CI. - The
metadata.annotations.createdAtfield in the CSV was updated to a later date even though this is essentially a revert; consider keeping this timestamp consistent with the original release or updating it only as part of an actual new build process.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In go.mod you downgraded the `go` directive to 1.22.9 but added `toolchain go1.22.11`, which seems to reintroduce the same version constraint you are trying to avoid; consider removing or aligning the toolchain directive with what is actually available in OpenShift CI.
- The `metadata.annotations.createdAt` field in the CSV was updated to a later date even though this is essentially a revert; consider keeping this timestamp consistent with the original release or updating it only as part of an actual new build process.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
nunnatsa
changed the title
Pull Request Test Coverage Report for Build 20005768770Details
💛 - Coveralls |
|
@nunnatsa: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Manual revert of #3735
We can't compile with AAQ 1.3.1 in openshift CI, as go1.22 there is 1.22.9, while AAQ 1.3.1 requires 1.22.11
Release note: