Merge pull request #24 from kirschbaum-development/analysis-qBbM4m

Apply fixes from StyleCI

Author: navneetrai

migrations/2019_05_22_142633_create_nova_chartjs_metric_values_table.php

@@ -8,8 +8,6 @@ class CreateNovaChartJsMetricValuesTable extends Migration
 {
     /**
      * Run the migrations.
-     *
-     * @return void
      */
     public function up()
     {
@@ -25,8 +23,6 @@ public function up()
 
     /**
      * Reverse the migrations.
-     *
-     * @return void
      */
     public function down()
     {

src/Contracts/Chartable.php

@@ -12,21 +12,21 @@ interface Chartable
     public function novaChartjsMetricValue(): MorphOne;
 
     /**
-     * Should return settings for Nova Chart in prescribed format
+     * Should return settings for Nova Chart in prescribed format.
      *
      * @return array
      */
     public static function getNovaChartjsSettings(): array;
 
     /**
-     * Return a list of all models available for comparison to root model
+     * Return a list of all models available for comparison to root model.
      *
      * @return array
      */
     public static function getNovaChartjsComparisonData(): array;
 
     /**
-     * Return a list of additional datasets added to chart
+     * Return a list of additional datasets added to chart.
      *
      * @return array
      */

src/Models/NovaChartjsMetricValue.php

@@ -26,7 +26,7 @@ class NovaChartjsMetricValue extends Model
     ];
 
     /**
-     * Return Chartable model for which this Metric Values are stored
+     * Return Chartable model for which this Metric Values are stored.
      *
      * @return MorphTo
      */

src/NovaChartjs.php

@@ -22,8 +22,6 @@ class NovaChartjs extends Field
      * @param  string  $name
      * @param  string|callable|null  $attribute
      * @param  callable|null  $resolveCallback
-     *
-     * @return void
      */
     public function __construct($name, $attribute = null, callable $resolveCallback = null)
     {
@@ -37,7 +35,7 @@ public function __construct($name, $attribute = null, callable $resolveCallback
     }
 
     /**
-     * Pass chartable model to NovaChartjs to fetch settings
+     * Pass chartable model to NovaChartjs to fetch settings.
      *
      * @param Chartable|null $chartable
      *
@@ -60,7 +58,7 @@ public function chartable(Chartable $chartable): self
     }
 
     /**
-     * Hide Label to make Chart occupy full width
+     * Hide Label to make Chart occupy full width.
      *
      * @return NovaChartjs
      */
@@ -72,7 +70,7 @@ public function showLabel(): self
     }
 
     /**
-     * set whether a user can edit a model data
+     * set whether a user can edit a model data.
      *
      * @return NovaChartjs
      */
@@ -87,7 +85,7 @@ public function notEditable(): self
     }
 
     /**
-     * Fetch a property from Chartable
+     * Fetch a property from Chartable.
      *
      * @param Chartable $chartable
      * @param string $prop

src/NovaChartjsServiceProvider.php

@@ -11,8 +11,6 @@ class NovaChartjsServiceProvider extends ServiceProvider
 {
     /**
      * Bootstrap any application services.
-     *
-     * @return void
      */
     public function boot()
     {
@@ -23,8 +21,6 @@ public function boot()
 
     /**
      * Register any application services.
-     *
-     * @return void
      */
     public function register()
     {

src/Traits/HasChart.php

@@ -8,7 +8,7 @@
 trait HasChart
 {
     /**
-     * Get the Chartable Model's metric values
+     * Get the Chartable Model's metric values.
      *
      * @return MorphOne
      */
@@ -18,7 +18,7 @@ public function novaChartjsMetricValue(): MorphOne
     }
 
     /**
-     * Delete a models chart data before model is deleted
+     * Delete a models chart data before model is deleted.
      */
     public static function bootHasNovaChartjsChart()
     {
@@ -30,7 +30,7 @@ public static function bootHasNovaChartjsChart()
     }
 
     /**
-     * Mutator to set Metric Values from Chartable model
+     * Mutator to set Metric Values from Chartable model.
      *
      * @param $value
      */
@@ -46,7 +46,7 @@ public function setNovaChartjsMetricValueAttribute($value): void
     }
 
     /**
-     * Return a list of all models available for comparison to root model
+     * Return a list of all models available for comparison to root model.
      *
      * @return \Illuminate\Database\Eloquent\Collection
      */
@@ -59,7 +59,7 @@ public static function getNovaChartjsComparisonData(): array
     }
 
     /**
-     * Return a list of additional datasets added to chart
+     * Return a list of additional datasets added to chart.
      *
      * @return array
      */

tests/Chartable.php

@@ -21,7 +21,7 @@ class Chartable extends Model
     protected $fillable = ['name'];
 
     /**
-     * Should return settings for Nova Chart in prescribed format
+     * Should return settings for Nova Chart in prescribed format.
      *
      * @return array
      */

tests/TestCase.php

@@ -11,7 +11,7 @@ abstract class TestCase extends Orchestra
     protected $testChartable;
 
     /**
-     * Setup the Tests
+     * Setup the Tests.
      */
     public function setUp(): void
     {
@@ -59,7 +59,7 @@ protected function setUpDatabase($app): void
     }
 
     /**
-     * Create Chartable Model for Testing
+     * Create Chartable Model for Testing.
      */
     protected function createTestModels(): void
     {

tests/Unit/ChartableTest.php

@@ -34,7 +34,7 @@ public function a_chartable_can_return_his_metric_value()
     }
 
     /**
-     * Adds a NovaChartjsMetricValue to a Chartable Model
+     * Adds a NovaChartjsMetricValue to a Chartable Model.
      *
      * @param NovaChartjsMetricValue|null $metricValue
      * @param Chartable|null $chartable