Fix poor perfofmance of line selection

Author: juzzlin

src/application/selection_service.cpp

@@ -112,7 +112,7 @@ bool SelectionService::requestSelectionEnd(size_t pattern, size_t track, size_t
         const Position position = { pattern, track, column, line };
         m_endPosition = position;
         juzzlin::L(TAG).info() << "New selection end: " << position.toString();
-        emit selectionChanged();
+        emit selectionChanged(*m_startPosition, *m_endPosition);
         emit isValidSelectionChanged();
         return true;
     }
@@ -122,10 +122,13 @@ bool SelectionService::requestSelectionEnd(size_t pattern, size_t track, size_t
 
 void SelectionService::clear()
 {
+    const auto prevStart = *m_startPosition;
+    const auto prevEnd = *m_endPosition;
+
     m_startPosition.reset();
     m_endPosition.reset();
 
-    emit selectionChanged();
+    emit selectionCleared(prevStart, prevEnd);
     emit isValidSelectionChanged();
 }
 

src/application/selection_service.hpp

@@ -49,7 +49,8 @@ class SelectionService : public QObject
 
 signals:
     void isValidSelectionChanged();
-    void selectionChanged();
+    void selectionCleared(const Position & startPosition, const Position & endPosition);
+    void selectionChanged(const Position & startPosition, const Position & endPosition);
 
 private:
     std::optional<Position> m_startPosition;

src/unit_tests/selection_service_test/CMakeLists.txt

@@ -3,6 +3,7 @@ set(NAME selection_service_test)
 set(SRC
     ${NAME}.cpp
     ${NAME}.hpp
+    ../../application/position.hpp
     ../../application/selection_service.cpp
 )
 add_executable(${NAME} ${SRC} ${MOC_SRC})

src/view/qml/Editor/EditorView.qml

@@ -212,6 +212,9 @@ FocusScope {
     function _updateIndexHighlights() {
         _patterns.forEach(pattern => pattern.updateIndexHighlights());
     }
+    function _updateSelectedLines(startPosition, endPosition) {
+        _patterns.filter(pattern => pattern.index() === startPosition.pattern).forEach(pattern => pattern.updateSelectedLines(startPosition, endPosition));
+    }
     function _addColumn(trackIndex) {
         _patterns.forEach(pattern => {
                 pattern.addColumn(trackIndex);
@@ -290,7 +293,8 @@ FocusScope {
                     });
             });
         mixerService.cleared.connect(_clearMixerSettings);
-        selectionService.selectionChanged.connect(_updateIndexHighlights);
+        selectionService.selectionChanged.connect(_updateSelectedLines);
+        selectionService.selectionCleared.connect(_updateSelectedLines);
     }
     function _lineNumberColumnHeight() {
         return trackArea.height - Constants.trackHeaderHeight - Constants.columnHeaderHeight;

src/view/qml/Editor/Pattern.qml

@@ -140,6 +140,9 @@ Item {
                 track.updateIndexHighlights();
             });
     }
+    function updateSelectedLines(startPosition, endPosition) {
+        _tracks.filter(track => track.index() === startPosition.track).forEach(track => track.updateIndexHighlights());
+    }
     function updateColumnHeaders() {
         _tracks.forEach(track => {
                 track.updateColumnHeaders();