Temperature unit improvements and feature (#11)

Use enum for temperature unit, setter for unit

Author: jpelgrom

letpot/converters.py

@@ -8,7 +8,12 @@
 from aiomqtt.types import PayloadType
 
 from letpot.exceptions import LetPotException
-from letpot.models import DeviceFeature, LetPotDeviceErrors, LetPotDeviceStatus
+from letpot.models import (
+    DeviceFeature,
+    TemperatureUnit,
+    LetPotDeviceErrors,
+    LetPotDeviceStatus,
+)
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -243,6 +248,7 @@ def supported_features(self) -> DeviceFeature:
             DeviceFeature.LIGHT_BRIGHTNESS_LEVELS
             | DeviceFeature.PUMP_AUTO
             | DeviceFeature.TEMPERATURE
+            | DeviceFeature.TEMPERATURE_SET_UNIT
             | DeviceFeature.WATER_LEVEL
         )
         if self._device_type != "LPH60":
@@ -270,7 +276,7 @@ def get_update_status_message(self, status: LetPotDeviceStatus) -> list[int]:
             if status.light_brightness is not None
             else 0,
             status.light_brightness % 256 if status.light_brightness is not None else 0,
-            status.temperature_unit if status.temperature_unit is not None else 0,
+            1 if status.temperature_unit is TemperatureUnit.CELSIUS else 0,
             1 if status.system_sound is True else 0,
             1 if status.pump_nutrient is True else 0,
         ]
@@ -299,7 +305,7 @@ def convert_hex_to_status(self, message: PayloadType) -> LetPotDeviceStatus | No
                 low_nutrients=True if data[7] & 1 else False,
                 refill_error=True if data[7] & 4 else False,
             ),
-            temperature_unit=data[24],
+            temperature_unit=TemperatureUnit(data[24]),
             temperature_value=256 * data[22] + data[23],
             water_level=256 * data[20] + data[21],
             water_mode=data[17],
@@ -376,7 +382,7 @@ def convert_hex_to_status(self, message: PayloadType) -> LetPotDeviceStatus | No
                 low_nutrients=True if data[7] & 1 else False,
                 refill_error=True if data[7] & 4 else False,
             ),
-            temperature_unit=data[24],
+            temperature_unit=TemperatureUnit(data[24]),
             temperature_value=256 * data[22] + data[23],
             water_level=256 * data[20] + data[21],
             water_mode=data[17],

letpot/deviceclient.py

@@ -17,7 +17,12 @@
     LetPotConnectionException,
     LetPotException,
 )
-from letpot.models import AuthenticationInfo, DeviceFeature, LetPotDeviceStatus
+from letpot.models import (
+    AuthenticationInfo,
+    DeviceFeature,
+    TemperatureUnit,
+    LetPotDeviceStatus,
+)
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -326,6 +331,11 @@ async def set_sound(self, on: bool) -> None:
         status = dataclasses.replace(self._get_publish_status(), system_sound=on)
         await self._publish_status(status)
 
+    async def set_temperature_unit(self, unit: TemperatureUnit) -> None:
+        """Set the temperature unit for this device (Celsius/Fahrenheit)."""
+        status = dataclasses.replace(self._get_publish_status(), temperature_unit=unit)
+        await self._publish_status(status)
+
     async def set_water_mode(self, on: bool) -> None:
         """Set the automatic water/nutrient mode for this device (on/off)."""
         status = dataclasses.replace(

letpot/models.py

@@ -2,7 +2,7 @@
 
 from dataclasses import dataclass
 from datetime import time
-from enum import IntFlag, auto
+from enum import IntEnum, IntFlag, auto
 import time as systime
 
 
@@ -15,9 +15,17 @@ class DeviceFeature(IntFlag):
     PUMP_AUTO = auto()
     PUMP_STATUS = auto()
     TEMPERATURE = auto()
+    TEMPERATURE_SET_UNIT = auto()
     WATER_LEVEL = auto()
 
 
+class TemperatureUnit(IntEnum):
+    """Device temperate sensor/display unit."""
+
+    FAHRENHEIT = 0
+    CELSIUS = 1
+
+
 @dataclass
 class AuthenticationInfo:
     """Authentication info model."""
@@ -73,7 +81,7 @@ class LetPotDeviceStatus:
     raw: list[int]
     system_on: bool
     system_sound: bool | None
-    temperature_unit: int | None = None
+    temperature_unit: TemperatureUnit | None = None
     temperature_value: int | None = None
     water_mode: int | None = None
     water_level: int | None = None