Skip to content

Conversation

@gounthar
Copy link
Contributor

@gounthar gounthar commented Nov 4, 2024

Hello gitlab-logo developers!

This is an automated pull request created by the Jenkins Plugin Modernizer tool. The tool has applied the following recipes to modernize the plugin:

Add Jenkinsfile

io.jenkins.tools.pluginmodernizer.AddOrModernizeJenkinsFile

Updates Jenkinsfile to build with recommended Java versions, platforms, and settings, or creates the file if absent. Also upgrades to a newer parent version, as the new version of the Jenkinsfille uses JDK17 and JDK21.
Add dependency check

io.jenkins.tools.pluginmodernizer.AddDependencyCheck

Adds a dependabot GitHub action to the plugin repository
Add plugins BOM

io.jenkins.tools.pluginmodernizer.AddPluginsBom

Add the Jenkins BOM to the dependenciesManagement section of the pom.xml.
Upgrade parent version

io.jenkins.tools.pluginmodernizer.UpgradeParentVersion

Upgrade the parent version to latest available
Remove dependency version override

io.jenkins.tools.pluginmodernizer.RemoveDependencyVersionOverride

Remove dependencies version override if managed from parent or bom
Remove extra maven properties

io.jenkins.tools.pluginmodernizer.RemoveExtraMavenProperties

Remove extra maven properties from the pom
Migrate from Java 11 to Java 17

io.jenkins.tools.pluginmodernizer.UpgradeToJava17

Migrate from Java 11 to Java 17
Add Jenkinsfile

io.jenkins.tools.pluginmodernizer.AddOrModernizeJenkinsFile

Updates Jenkinsfile to build with recommended Java versions, platforms, and settings, or creates the file if absent. Also upgrades to a newer parent version, as the new version of the Jenkinsfille uses JDK17 and JDK21.
Add dependency check

io.jenkins.tools.pluginmodernizer.AddDependencyCheck

Adds a dependabot GitHub action to the plugin repository
Upgrade to latest recommended core version and ensure the bom is matching the core version

io.jenkins.tools.pluginmodernizer.UpgradeToRecommendCoreVersion

Upgrade to latest recommended core version and ensure the bom is matching the core version

Unfortunately, this won't build for the time being, as the Jenkinsfile in the master branch still uses JDK8.
A maintainer would have to re-run the checks with the proposed Jenkinsfile for this PR to build.

Java version: 1.8.0_432, vendor: Temurin, runtime: /opt/jdk-8/jre
|...]
18:16:17  [ERROR] [ERROR] Some problems were encountered while processing the POMs:
18:16:17  [ERROR] Unknown packaging: hpi

Thanks. 🙏

@gounthar gounthar changed the title Applied recipes AddOrModernizeJenkinsFile, AddDependencyCheck, AddPluginsBom, UpgradeParentVersion, RemoveDependencyVersionOverride, RemoveExtraMavenProperties, UpgradeToJava17, AddOrModernizeJenkinsFile, AddDependencyCheck, UpgradeToRecommendCoreVersion chore(maven): Plugin modernization Nov 4, 2024
…ginsBom, UpgradeParentVersion, RemoveDependencyVersionOverride, RemoveExtraMavenProperties, UpgradeToJava17, AddOrModernizeJenkinsFile, AddDependencyCheck, UpgradeToRecommendCoreVersion, MigrateJUnitTestCase
@gounthar gounthar force-pushed the plugin-modernizer-tool branch from 97fddf7 to bba34ba Compare November 4, 2024 17:14
@sue445 sue445 self-requested a review November 4, 2024 22:46
sue445 added a commit that referenced this pull request Nov 5, 2024
@sue445 sue445 mentioned this pull request Nov 5, 2024
6 tasks
@sue445
Copy link
Contributor

sue445 commented Nov 5, 2024

@gounthar Thank you for your contribution!

I have applied only the Jenkinsfile fixes included in this patch by #75

Is this ok?

@gounthar
Copy link
Contributor Author

gounthar commented Nov 5, 2024

Yes, thank you.
The build checks pass now. 👍

Copy link
Contributor

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@sue445 sue445 merged commit 48b9808 into jenkinsci:master Nov 5, 2024
16 checks passed
@gounthar gounthar deleted the plugin-modernizer-tool branch November 5, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants