chore(jslint): cleanup jslint errors + smaller fixes

Author: pbernasconi

src/plugins/adMob.js

@@ -65,5 +65,5 @@ angular.module('ngCordova.plugins.adMob', [])
 
         return d.promise;
       }
-    }
+    };
   }]);

src/plugins/appAvailability.js

@@ -17,5 +17,5 @@ angular.module('ngCordova.plugins.appAvailability', [])
 
       return q.promise;
     }
-  }
+  };
 }]);

src/plugins/badge.js

@@ -71,5 +71,5 @@ angular.module('ngCordova.plugins.badge', [])
       configure: function (config) {
         return cordova.plugins.notification.badge.configure(config);
       }
-    }
+    };
   }]);

src/plugins/barcodeScanner.js

@@ -6,7 +6,7 @@ angular.module('ngCordova.plugins.barcodeScanner', [])
   .factory('$cordovaBarcodeScanner', ['$q', function ($q) {
 
     return {
-      scan: function (options) {
+      scan: function () {
         var q = $q.defer();
 
         cordova.plugins.barcodeScanner.scan(function (result) {
@@ -20,13 +20,7 @@ angular.module('ngCordova.plugins.barcodeScanner', [])
 
       encode: function (type, data) {
         var q = $q.defer();
-
-        /* TODO needs work for type:
-         make the default:  BarcodeScanner.Encode.TEXT_TYPE
-         other options: .EMAIL_TYPE, .PHONE_TYPE, .SMS_TYPE
-
-         docs: https://github.com/wildabeast/BarcodeScanner#encoding-a-barcode
-         */
+        type = type || "TEXT_TYPE";
 
         cordova.plugins.barcodeScanner.encode(type, data, function (result) {
           q.resolve(result);
@@ -36,5 +30,5 @@ angular.module('ngCordova.plugins.barcodeScanner', [])
 
         return q.promise;
       }
-    }
+    };
   }]);

src/plugins/ble.js

@@ -3,11 +3,11 @@
 
 angular.module('ngCordova.plugins.ble', [])
 
-  .factory('$cordovaBLE', ['$q', '$window', function ($q, $window) {
+  .factory('$cordovaBLE', ['$q', function ($q) {
 
     return {
       scan: function (services, seconds) {
-        var q = q.defer();
+        var q = $q.defer();
         ble.scan(services, seconds, function (result) {
           q.resolve(result);
         }, function (error) {
@@ -17,16 +17,17 @@ angular.module('ngCordova.plugins.ble', [])
       },
 
       connect: function (deviceID) {
-        var q = q.defer();
+        var q = $q.defer();
         ble.connect(deviceID, function (result) {
           q.resolve(result);
         }, function (error) {
           q.reject(error);
         });
         return q.promise;
       },
+
       disconnect: function (deviceID) {
-        var q = q.defer();
+        var q = $q.defer();
         ble.disconnect(deviceID, function (result) {
           q.resolve(result);
         }, function (error) {
@@ -36,7 +37,7 @@ angular.module('ngCordova.plugins.ble', [])
       },
 
       read: function (deviceID, serviceUUID, characteristicUUID) {
-        var q = q.defer();
+        var q = $q.defer();
         ble.read(deviceID, serviceUUID, characteristicUUID, function (result) {
           q.resolve(result);
         }, function (error) {
@@ -46,7 +47,7 @@ angular.module('ngCordova.plugins.ble', [])
       },
 
       write: function (deviceID, serviceUUID, characteristicUUID, data) {
-        var q = q.defer();
+        var q = $q.defer();
         ble.write(deviceID, serviceUUID, characteristicUUID, data, function (result) {
           q.resolve(result);
         }, function (error) {
@@ -56,7 +57,7 @@ angular.module('ngCordova.plugins.ble', [])
       },
 
       writeCommand: function (deviceID, serviceUUID, characteristicUUID, data) {
-        var q = q.defer();
+        var q = $q.defer();
         ble.writeCommand(deviceID, serviceUUID, characteristicUUID, data, function (result) {
           q.resolve(result);
         }, function (error) {
@@ -66,7 +67,7 @@ angular.module('ngCordova.plugins.ble', [])
       },
 
       notify: function (deviceID, serviceUUID, characteristicUUID) {
-        var q = q.defer();
+        var q = $q.defer();
         ble.notify(deviceID, serviceUUID, characteristicUUID, function (result) {
           q.resolve(result);
         }, function (error) {
@@ -76,7 +77,7 @@ angular.module('ngCordova.plugins.ble', [])
       },
 
       indicate: function (deviceID, serviceUUID, characteristicUUID) {
-        var q = q.defer();
+        var q = $q.defer();
         ble.indicate(deviceID, serviceUUID, characteristicUUID, function (result) {
           q.resolve(result);
         }, function (error) {
@@ -86,7 +87,7 @@ angular.module('ngCordova.plugins.ble', [])
       },
 
       isConnected: function (deviceID) {
-        var q = q.defer();
+        var q = $q.defer();
         ble.isConnected(deviceID, function (result) {
           q.resolve(result);
         }, function (error) {
@@ -96,13 +97,13 @@ angular.module('ngCordova.plugins.ble', [])
       },
 
       isEnabled: function () {
-        var q = q.defer();
+        var q = $q.defer();
         ble.isEnabled(function (result) {
           q.resolve(result);
         }, function (error) {
           q.reject(error);
         });
         return q.promise;
       }
-    }
+    };
   }]);

src/plugins/camera.js

@@ -34,5 +34,5 @@ angular.module('ngCordova.plugins.camera', [])
 
         return q.promise;
       }
-    }
+    };
   }]);

src/plugins/capture.js

@@ -54,5 +54,5 @@ angular.module('ngCordova.plugins.capture', [])
 
         return q.promise;
       }
-    }
+    };
   }]);

src/plugins/clipboard.js

@@ -30,5 +30,5 @@ angular.module('ngCordova.plugins.clipboard', [])
 
         return q.promise;
       }
-    }
+    };
   }]);

src/plugins/contacts.js

@@ -53,14 +53,14 @@ angular.module('ngCordova.plugins.contacts', [])
         return q.promise;
       },
 
-      pickContact: function() {
+      pickContact: function () {
         var q = $q.defer();
 
         navigator.contacts.pickContact(
-          function(contact) {
+          function (contact) {
             q.resolve(contact);
           },
-          function(err) {
+          function (err) {
             q.reject(err);
           }
         );

src/plugins/datepicker.js

@@ -3,7 +3,7 @@ angular.module('ngCordova.plugins.datePicker', [])
   .factory('$cordovaDatePicker', ['$window', '$q', function ($window, $q) {
 
     return {
-      show: function(options) {
+      show: function (options) {
         var d = $q.defer();
 
         $window.datePicker.show(options, function (date) {
@@ -12,6 +12,5 @@ angular.module('ngCordova.plugins.datePicker', [])
 
         return d.promise;
       }
-    }
-
+    };
   }]);