Skip to content

Commit 465c868

Browse files
committed
🔥 Remove legacy GeneratedReview structured review system
Delete the backwards-compatibility code path for dimension-based code reviews in favor of the simpler MarkdownReview approach. - Remove GeneratedReview, CodeIssue, DimensionAnalysis, and QualityDimension types along with their formatting implementations (~600 lines) - Remove Review variant from StructuredResponse enum in iris.rs - Clean up unused imports (textwrap, SUCCESS_GREEN) and constants - Update public exports in lib.rs and types/mod.rs - Remove obsolete tests for legacy review formatting
1 parent 12c3b4c commit 465c868

File tree

5 files changed

+7
-749
lines changed

5 files changed

+7
-749
lines changed

src/agents/iris.rs

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,8 @@ pub enum StructuredResponse {
5959
PullRequest(crate::types::GeneratedPullRequest),
6060
Changelog(crate::types::ChangelogResponse),
6161
ReleaseNotes(crate::types::ReleaseNotesResponse),
62-
/// New markdown-based review (LLM-driven structure)
62+
/// Markdown-based review (LLM-driven structure)
6363
MarkdownReview(crate::types::MarkdownReview),
64-
/// Legacy structured review (kept for backwards compatibility)
65-
Review(Box<crate::types::GeneratedReview>),
6664
PlainText(String),
6765
}
6866

@@ -84,9 +82,6 @@ impl fmt::Display for StructuredResponse {
8482
StructuredResponse::MarkdownReview(review) => {
8583
write!(f, "{}", review.format())
8684
}
87-
StructuredResponse::Review(review) => {
88-
write!(f, "{}", review.format())
89-
}
9085
StructuredResponse::PlainText(text) => {
9186
write!(f, "{text}")
9287
}
@@ -740,16 +735,6 @@ Guidelines:
740735
.await?;
741736
Ok(StructuredResponse::MarkdownReview(response))
742737
}
743-
// Legacy structured review (kept for backwards compatibility)
744-
"GeneratedReview" => {
745-
let response = self
746-
.execute_with_agent::<crate::types::GeneratedReview>(
747-
&system_prompt,
748-
user_prompt,
749-
)
750-
.await?;
751-
Ok(StructuredResponse::Review(Box::new(response)))
752-
}
753738
_ => {
754739
// Fallback to regular agent for unknown types
755740
let agent = self.build_agent()?;

src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,6 @@ pub use providers::{Provider, ProviderConfig};
3838

3939
// Re-exports from types module
4040
pub use types::{
41-
CodeIssue, DimensionAnalysis, GeneratedMessage, GeneratedPullRequest, GeneratedReview,
42-
MarkdownReview, QualityDimension, format_commit_message, format_pull_request,
41+
GeneratedMessage, GeneratedPullRequest, MarkdownReview, format_commit_message,
42+
format_pull_request,
4343
};

src/types/mod.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ pub use self::commit::{GeneratedMessage, format_commit_message};
2020
pub use pr::{GeneratedPullRequest, format_pull_request};
2121

2222
// Review types
23-
pub use review::{
24-
CodeIssue, DimensionAnalysis, GeneratedReview, MarkdownReview, QualityDimension,
25-
render_markdown_for_terminal,
26-
};
23+
pub use review::{MarkdownReview, render_markdown_for_terminal};
2724

2825
// Changelog types
2926
pub use changelog::{BreakingChange, ChangeEntry, ChangeMetrics, ChangelogResponse, ChangelogType};

0 commit comments

Comments
 (0)