Don't assume Params type (#3028)

* Don't assume Params type. Fixes #2943

* Add failing test for unfixed code.

* Ignore screencast tests on Firefox.

* Bump version to 20.2.5.

* Add test ID.

Co-authored-by: Darío Kondratiuk <[email protected]>

* Use correct test ID.

Co-authored-by: Darío Kondratiuk <[email protected]>

* Add missing using.

Co-authored-by: Darío Kondratiuk <[email protected]>

---------

Co-authored-by: Darío Kondratiuk <[email protected]>

Author: bgrainger

lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json

@@ -62,6 +62,13 @@
     "parameters": ["firefox"],
     "expectations": ["FAIL"]
   },
+  {
+    "comment": "TODO Review screencasts in firefox",
+    "testIdPattern": "[puppeteer-sharp] Screencast*",
+    "platforms": ["linux", "win32"],
+    "parameters": ["firefox"],
+    "expectations": ["FAIL"]
+  },
   {
     "comment": "TODO Review screenshots in firefox",
     "testIdPattern": "[screenshot.spec] *",

lib/PuppeteerSharp.Tests/ScreencastTests/PageScreencastTests.cs

@@ -0,0 +1,48 @@
+using System.Threading.Tasks;
+using NUnit.Framework;
+using PuppeteerSharp.Nunit;
+
+namespace PuppeteerSharp.Tests.ScreencastTests
+{
+    public class PageScreencastTests : PuppeteerBrowserContextBaseTest
+    {
+        [Test, PuppeteerTest("puppeteer-sharp", "Screencast", "can start screencast")]
+        public async Task CanStartScreencast()
+        {
+            await using var page = await Context.NewPageAsync();
+            await page.SetViewportAsync(new ViewPortOptions
+            {
+                Width = 500,
+                Height = 500
+            });
+
+            var screencastFramesReceived = 0;
+            page.Client.MessageReceived += async (_, e) =>
+            {
+                if (e.MessageID == "Page.screencastFrame")
+                {
+                    Assert.That(e.MessageData.GetProperty("data").GetString(), Is.Not.Null.Or.Empty);
+                    screencastFramesReceived++;
+
+                    // acknowledge frame
+                    await page.Client.SendAsync("Page.screencastFrameAck", new
+                    {
+                        sessionId = e.MessageData.GetProperty("sessionId").GetInt32(),
+                    });
+                }
+            };
+
+            await page.Client.SendAsync("Page.startScreencast", new
+            {
+                format = "png",
+                everyNthFrame = 1
+            });
+
+            await page.GoToAsync(TestConstants.ServerUrl + "/grid.html");
+
+            await page.Client.SendAsync("Page.stopScreencast");
+
+            Assert.That(screencastFramesReceived, Is.GreaterThan(0));
+        }
+    }
+}

lib/PuppeteerSharp/Cdp/Connection.cs

@@ -303,10 +303,10 @@ private async Task ProcessMessage(MessageReceivedEventArgs e)
         private void ProcessIncomingMessage(ConnectionResponse obj)
         {
             var method = obj.Method;
-            var param = obj.Params?.ToObject<ConnectionResponseParams>();
 
             if (method == "Target.attachedToTarget")
             {
+                var param = obj.Params?.ToObject<ConnectionResponseParams>();
                 var sessionId = param.SessionId;
                 var session = new CdpCDPSession(this, param.TargetInfo.Type, sessionId, obj.SessionId);
                 _sessions.AddItem(sessionId, session);
@@ -320,6 +320,7 @@ private void ProcessIncomingMessage(ConnectionResponse obj)
             }
             else if (method == "Target.detachedFromTarget")
             {
+                var param = obj.Params?.ToObject<ConnectionResponseParams>();
                 var sessionId = param.SessionId;
                 if (_sessions.TryRemove(sessionId, out var session) && !session.IsClosed)
                 {

lib/PuppeteerSharp/PuppeteerSharp.csproj

@@ -12,10 +12,10 @@
     <Description>Headless Browser .NET API</Description>
     <PackageId>PuppeteerSharp</PackageId>
     <PackageReleaseNotes></PackageReleaseNotes>
-    <PackageVersion>20.2.4</PackageVersion>
-    <ReleaseVersion>20.2.4</ReleaseVersion>
-    <AssemblyVersion>20.2.4</AssemblyVersion>
-    <FileVersion>20.2.4</FileVersion>
+    <PackageVersion>20.2.5</PackageVersion>
+    <ReleaseVersion>20.2.5</ReleaseVersion>
+    <AssemblyVersion>20.2.5</AssemblyVersion>
+    <FileVersion>20.2.5</FileVersion>
     <SynchReleaseVersion>false</SynchReleaseVersion>
     <StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
     <DebugType>embedded</DebugType>