Skip to content

Cliff Click solution seems to be not handling collisions properly #719

@tivrfoa

Description

@tivrfoa

Hi @cliffclick

It seems your code relies that uhash is unique, but here is an example of collision:

  • Khān
  • Shām

https://github.com/gunnarmorling/1brc/blob/main/src/main/java/dev/morling/onebrc/CalculateAverage_cliffclick.java#L278

I discovered this because I ran your code, and the output is different for the create_measurements3.sh

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions