test: reuse fake http server

Author: antongolub

test/cli.test.js

@@ -19,23 +19,12 @@ import net from 'node:net'
 import getPort from 'get-port'
 import { $, path, tmpfile, tmpdir, fs } from '../build/index.js'
 import { isMain, normalizeExt } from '../build/cli.js'
+import { fakeServer } from './fixtures/server.mjs'
 
 const __filename = fileURLToPath(import.meta.url)
 const spawn = $.spawn
 const nodeMajor = +process.versions?.node?.split('.')[0]
 const test22 = nodeMajor >= 22 ? test : test.skip
-const getServer = (resp = [], log = console.log) => {
-  const server = net.createServer()
-  server.on('connection', (conn) => {
-    conn.on('data', (d) => {
-      conn.write(resp.shift() || 'pong')
-    })
-  })
-  server.stop = () => new Promise((resolve) => server.close(() => resolve()))
-  server.start = (port) =>
-    new Promise((resolve) => server.listen(port, () => resolve(server)))
-  return server
-}
 
 describe('cli', () => {
   // Helps to detect unresolved ProcessPromise.
@@ -213,7 +202,7 @@ console.log(a);
   test('scripts from https 200', async () => {
     const resp = await fs.readFile(path.resolve('test/fixtures/echo.http'))
     const port = await getPort()
-    const server = await getServer([resp]).start(port)
+    const server = await fakeServer([resp]).start(port)
     const out =
       await $`node build/cli.js --verbose http://127.0.0.1:${port}/script.mjs`
     assert.match(out.stderr, /test/)
@@ -222,7 +211,7 @@ console.log(a);
 
   test('scripts from https 500', async () => {
     const port = await getPort()
-    const server = await getServer(['HTTP/1.1 500\n\n']).listen(port)
+    const server = await fakeServer(['HTTP/1.1 500\n\n']).listen(port)
     const out = await $`node build/cli.js http://127.0.0.1:${port}`.nothrow()
     assert.match(out.stderr, /Error: Can't get/)
     await server.stop()
@@ -231,7 +220,7 @@ console.log(a);
   test('scripts (md) from https', async () => {
     const resp = await fs.readFile(path.resolve('test/fixtures/md.http'))
     const port = await getPort()
-    const server = await getServer([resp]).start(port)
+    const server = await fakeServer([resp]).start(port)
     const out =
       await $`node build/cli.js --verbose http://127.0.0.1:${port}/script.md`
     assert.match(out.stderr, /md/)

test/fixtures/server.mjs

@@ -0,0 +1,34 @@
+// Copyright 2025 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+import net from 'node:net'
+
+export const fakeServer = (data = []) => {
+  const server = net.createServer()
+  server.on('connection', (conn) => {
+    conn.on('data', () => {
+      const d = data.shift() || 'pong'
+      const _d = typeof d === 'string' ? d.replaceAll('\n', '\r\n') : d
+      conn.write(_d)
+    })
+  })
+  server.stop = () => new Promise((resolve) => server.close(() => resolve()))
+  server.start = async (port) => {
+    const p = port || (await (await import('get-port')).getPort())
+    server.url = `http://127.0.0.1:${port}`
+    return new Promise((resolve) => server.listen(port, () => resolve(server)))
+  }
+
+  return server
+}

test/smoke/node.test.cjs

@@ -26,6 +26,6 @@ require('zx/globals')
     const p = await $({ nothrow: true })`echo foo; exit 3`
     assert.match(p.message, /exit code: 3/)
   }
-})()
 
-console.log('smoke cjs: ok')
+  console.log('smoke cjs: ok')
+})()

test/smoke/node.test.mjs

@@ -93,12 +93,24 @@ import 'zx/globals'
 
   // fetch()
   {
-    const url = 'https://httpbin.org/get'
+    const server = (await import('../fixtures/server.mjs')).fakeServer([
+      `HTTP/1.1 200 OK
+Content-Type: application/json
+Content-Length: 13
+Server: netcat!
+
+{"foo":"bar"}
+`,
+    ])
+
+    const { url } = await server.start(8081)
     const res = await fetch(url)
     const json = await res.json()
     assert.equal(res.status, 200)
-    assert.equal(json.url, url)
+    assert.equal(json.foo, 'bar')
+
+    await server.stop()
   }
-})()
 
-console.log('smoke mjs: ok')
+  console.log('smoke mjs: ok')
+})()