✨ Improve ordering of missing patterns #5187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
fruno-bulax
changed the title
Member
|
Oh wow now list patterns, bools and results are nicely ordered. Love this 💖 Just left a comment for some clarification |
fruno-bulax
force-pushed
the
order-missing-patterns
branch
2 times, most recently
from
74d6b4b to
77e0b65
Compare
fruno-bulax
force-pushed
the
order-missing-patterns
branch
from
77e0b65 to
29f8a11
Compare
lpil
approved these changes
Dec 8, 2025
| [_, _] -> todo | ||
| [_, _, _] -> todo | ||
| [_, _, _, _] -> todo | ||
| [_, _, _, _, _, ..] -> todo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5184.
The implementation of this did not go as expected.
In short, we naturally already construct the missing patterns in a very intuitive order.
However, there can be duplicate patterns involving wildcards, which is probably why the strings were put in a set, losing that order. To then regain a stable order, the patterns were sorted lexicographically.
This PR maintains the original order and keeps the set only to prune duplicates.
As you can see from the updated snapshots, this has the nice side effect of also ordering list patterns by the number of elements being matched on.