Add wasm package #53
Merged
Add wasm package #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us compile the lib into wasm and adds a npm wrapper package for it I had to rearrange the code slightly to split out any methods using wasm incompatible types. Not sure if there's a better way to do this
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds WebAssembly support for the library along with an npm wrapper package.
- Adds documentation for building and publishing the npm/wasm package.
- Introduces tests for the WASM package in the JS wrapper.
- Applies wasm-bindgen annotations and adjusts Cargo.toml to support WASM builds.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/string-offsets/CONTRIBUTING.md | Adds instructions for building, testing, and publishing the WASM/JS package. |
| crates/string-offsets/js/test/test.js | Introduces sanity-check tests for the WASM package. |
| crates/string-offsets/src/lib.rs | Applies wasm-bindgen attributes and reorganizes method implementations. |
| crates/string-offsets/Cargo.toml | Configures the library for CDYLIB builds and adds the wasm-bindgen dependency. |
Files not reviewed (2)
- crates/string-offsets/.gitignore: Language not supported
- crates/string-offsets/js/package.json: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
tclem
approved these changes
Mar 13, 2025
Member
tclem
left a comment
tclem
left a comment
There was a problem hiding this comment.
Very cool, looks great to me. Having to move some methods to another impl block seems fine.
(Maybe as a follow up, we should add this to the Actions CI workflow)
aneubeck
reviewed
Mar 14, 2025
aneubeck
reviewed
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us compile the lib into wasm and adds a npm wrapper package for it
I had to rearrange the code slightly to split out any methods using wasm incompatible types. Not sure if there's a better way to do this