Enums within namespaces: Clang warning, C++11 feature

[IngwiePhoenix]

Whilst building, I encountered a warning several times - here is a snippet:

> ./ext/./minihttp/minihttp.cpp:37:44: warning: use of enumeration in a nested name specifier is a C++11 extension [-Wc++11-extensions]
>             {OS_TEXT("SSLR_OK"), minihttp::SSLResult::SSLR_OK},
>                                            ^

I was confused at first, but when I put the warning into google, I ended up here: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150112/121520.html
If you scroll down, you can see a testcase, which demonstrates this:

+namespace PR16951 {
+  namespace ns {
+    enum an_enumeration {
+      ENUMERATOR  // expected-note{{'ENUMERATOR' declared here}}
+    };
+  }
+
+  int x1 = ns::an_enumeration::ENUMERATOR; // expected-warning{{use of enumeration in a nested name specifier is a C++11 extension}}

So as it turns out, putting an enum into a namespace is C++11 and upwards. I myself was...well, surprised wouldn't suit it. But I would have assumed that naturally, anything can go into a namespace - turns out this is wrong.

So I'd like to ask for these enums to be moved upwards and renamed. It's just two anyway:

• minihttp::SSLResult -> minihttp_SSLResult
• minihttp::HttpCode -> minihttp_HttpCode

I am just suggesting these, but they would make the most sense, and allow non-C++11 compilers to not become confused :)

[IngwiePhoenix]

Oh yeah, I am using branch "ssl".

[fgenesis]

What. Even MSVC2008 supports that. I had no idea this was a C++11 feature. Okay, will change it next time i touch it.

[IngwiePhoenix]

In comparsion to GCC/Clang, MSVC "silently" supports things (at least so I am being told!). So, you can use C++11 even without knowing it is c++11 :). That is Microsoft’s idea of transparent feature additions, I guess...

[tivolo]

Note that this warning is not caused by putting an enum into a namespace, but rather because of the calling code. Consider:

enum Mode
{
READ,
WRITE
};

Handle OpenFile(Mode mode)
{
//...
}

OpenFile(READ); // correct!
OpenFile(Mode::READ); // nested name specifier, C++11 extension